Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Andy Shevchenko
On Wed, Sep 9, 2020 at 10:40 AM Greg Kroah-Hartman wrote: > On Wed, Sep 09, 2020 at 09:08:14AM +0200, Krzysztof Kozlowski wrote: > > On Wed, 9 Sep 2020 at 09:02, Greg Kroah-Hartman > > wrote: > > > On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > > > > On Wed, 26 Aug 2020

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Greg Kroah-Hartman
On Wed, Sep 09, 2020 at 09:08:14AM +0200, Krzysztof Kozlowski wrote: > On Wed, 9 Sep 2020 at 09:02, Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > > > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > > > > > On Wed, 2020-08-26

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Krzysztof Kozlowski
On Wed, 9 Sep 2020 at 09:02, Greg Kroah-Hartman wrote: > > On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > > > On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > > > > On Wed, Aug 26, 2020 at 08:44:30AM

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Greg Kroah-Hartman
On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > > > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > > > > On Wed, 2020-08-26 at 13:44 +0300,

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Krzysztof Kozlowski
On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > > > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: > > > > ... > > > > > > -int dev_err_probe(const struct

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Joe Perches
On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: > > ... > > > > -int dev_err_probe(const struct device *dev, int err, const char *fmt, > > > ...); > > > +int

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Andy Shevchenko
On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: ... > > -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); > > +int __must_check dev_err_probe(const struct device *dev, int err, const > > char

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Joe Perches
On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: > We have got already new users of this API which interpret it differently > and miss the opportunity to optimize their code. > > In order to avoid similar cases in the future, annotate dev_err_probe() > with __must_check. > > Fixes:

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Andy Shevchenko
On Wed, Aug 26, 2020 at 01:23:40PM +0200, Andrzej Hajda wrote: > On 26.08.2020 12:44, Andy Shevchenko wrote: > > We have got already new users of this API which interpret it differently > > and miss the opportunity to optimize their code. > > > > In order to avoid similar cases in the future,

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Andrzej Hajda
Hi Andy, On 26.08.2020 12:44, Andy Shevchenko wrote: > We have got already new users of this API which interpret it differently > and miss the opportunity to optimize their code. > > In order to avoid similar cases in the future, annotate dev_err_probe() > with __must_check. There are many

[PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-08-26 Thread Andy Shevchenko
We have got already new users of this API which interpret it differently and miss the opportunity to optimize their code. In order to avoid similar cases in the future, annotate dev_err_probe() with __must_check. Fixes: a787e5400a1c ("driver core: add device probe log helper") Signed-off-by: