Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Alex Qiu
On Thu, Oct 1, 2020 at 11:51 AM Andy Shevchenko wrote: > > I see. So, there are following statements: > - the elaboration is good but I guess needs to be added somewhere in > form of the documentation > - the internal schedules or so are not crucial for the upstream (it > rather sounds like a br

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 1, 2020 at 9:42 PM Avi Fishman wrote: > > Tali indeed pointed our major customers (Alex represent one of them :) > that this feature must be handled carefully since it may break the > communication and they are aware of that. Nevertheless they still want > this feature, they already re

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Avi Fishman
Tali indeed pointed our major customers (Alex represent one of them :) that this feature must be handled carefully since it may break the communication and they are aware of that. Nevertheless they still want this feature, they already reviewed this and accepted it (in internal mails) So we will a

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Alex Qiu
On Thu, Oct 1, 2020 at 10:41 AM Andy Shevchenko wrote: > > On Thu, Oct 01, 2020 at 08:13:49PM +0300, Avi Fishman wrote: > > Hi Andy, > > > > Customers using BMC with complex i2c topology asked us to support > > changing bus frequency at run time, for example same device will > > communicate with o

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 01, 2020 at 08:13:49PM +0300, Avi Fishman wrote: > Hi Andy, > > Customers using BMC with complex i2c topology asked us to support > changing bus frequency at run time, for example same device will > communicate with one slave at 100Kbp/s and another with 400kbp/s and > maybe also with

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Avi Fishman
Hi Andy, Customers using BMC with complex i2c topology asked us to support changing bus frequency at run time, for example same device will communicate with one slave at 100Kbp/s and another with 400kbp/s and maybe also with smae device at different speed (for example an i2c mux). This is not only

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 1, 2020 at 8:34 AM Tali Perry wrote: > On Wed, Sep 30, 2020 at 12:31 PM Andy Shevchenko > wrote: > > > > On Wed, Sep 30, 2020 at 10:13:42AM +0300, Tali Perry wrote: > > > Systems that can dinamically add and remove slave devices > > > > dynamically > > > > > often need to change the b

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-09-30 Thread Tali Perry
On Wed, Sep 30, 2020 at 12:31 PM Andy Shevchenko wrote: > > On Wed, Sep 30, 2020 at 10:13:42AM +0300, Tali Perry wrote: > > Systems that can dinamically add and remove slave devices > > dynamically > > > often need to change the bus speed in runtime. > > > This patch exposes the bus frequency to t

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-09-30 Thread Andy Shevchenko
On Wed, Sep 30, 2020 at 10:13:42AM +0300, Tali Perry wrote: > Systems that can dinamically add and remove slave devices dynamically > often need to change the bus speed in runtime. > This patch exposes the bus frequency to the user. Expose the bus frequency to the user. > This feature can also

[PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-09-30 Thread Tali Perry
Systems that can dinamically add and remove slave devices often need to change the bus speed in runtime. This patch exposes the bus frequency to the user. This feature can also be used for test automation. Fixes: 56a1485b102e (i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver) Signed-off-by: Ta