Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-03-12 Thread Luis Chamberlain
On Tue, Mar 12, 2024 at 03:25:27PM -0700, Luis Chamberlain wrote: > On Tue, Feb 13, 2024 at 02:10:45PM +0300, Andrew Kanner wrote: > > On Thu, Feb 01, 2024 at 10:13:54AM -0800, Luis Chamberlain wrote: > > > > > > While you're at it, if you want to try it, you could see if you can > > > improve

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-03-12 Thread Luis Chamberlain
On Tue, Feb 13, 2024 at 02:10:45PM +0300, Andrew Kanner wrote: > On Thu, Feb 01, 2024 at 10:13:54AM -0800, Luis Chamberlain wrote: > > > > While you're at it, if you want to try it, you could see if you can > > improve the situation more by looking at symbol_get() users that remain > > and seeing

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-13 Thread Andrew Kanner
On Thu, Feb 01, 2024 at 10:13:54AM -0800, Luis Chamberlain wrote: > > While you're at it, if you want to try it, you could see if you can > improve the situation more by looking at symbol_get() users that remain > and seeing if you can instead fix it with proper Kconfig dependency and > at build

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-01 Thread Christoph Hellwig
On Thu, Feb 01, 2024 at 12:29:46PM +0300, Andrew Kanner wrote: > Of course not, no new users needed. > > I haven't discussed it directly. I found the unused __symbol_get_gpl() > myself, but during investigation of wether it was ever used somewhere > found the old patch series suggested by Mauro

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-01 Thread Luis Chamberlain
On Thu, Feb 01, 2024 at 12:29:46PM +0300, Andrew Kanner wrote: > On Thu, Feb 01, 2024 at 06:29:58AM +0100, Christoph Hellwig wrote: > > On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote: > > > Prototype for __symbol_get_gpl() was introduced in the initial git > > > commit 1da177e4c3f4

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-01 Thread Andrew Kanner
On Thu, Feb 01, 2024 at 06:29:58AM +0100, Christoph Hellwig wrote: > On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote: > > Prototype for __symbol_get_gpl() was introduced in the initial git > > commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that. > > > > In commit

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-01-31 Thread Christoph Hellwig
On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote: > Prototype for __symbol_get_gpl() was introduced in the initial git > commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that. > > In commit 9011e49d54dc ("modules: only allow symbol_get of > EXPORT_SYMBOL_GPL modules")

[PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-01-31 Thread Andrew Kanner
Prototype for __symbol_get_gpl() was introduced in the initial git commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") Christoph Hellwig switched __symbol_get() to process GPL symbols only,