RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-17 Thread Andy Duan
From: Sven Van Asbroeck Sent: Wednesday, July 17, 2019 8:48 PM > On Tue, Jul 16, 2019 at 9:32 PM Andy Duan wrote: > > > > Yes, so the old legacy code is kept there. But it is better to clean > > up all if there have enough boards to verify them. > > Would it make sense to print a warning

Re: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-17 Thread Sven Van Asbroeck
On Tue, Jul 16, 2019 at 9:32 PM Andy Duan wrote: > > Yes, so the old legacy code is kept there. But it is better to clean up all if > there have enough boards to verify them. Would it make sense to print a warning message to the log whenever someone tries to use the legacy phy reset on the fec?

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-16 Thread Andy Duan
From: Sven Van Asbroeck Sent: Tuesday, July 16, 2019 9:19 PM > Hi Andy, > > On Mon, Jul 15, 2019 at 10:02 PM Andy Duan > wrote: > > > > the phylib already can handle mii bus reset and phy device reset > > That's a great suggestion, thank you !! I completely overlooked that code. > What will

Re: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-16 Thread Sven Van Asbroeck
Hi Andy, On Mon, Jul 15, 2019 at 10:02 PM Andy Duan wrote: > > the phylib already can handle mii bus reset and phy device reset That's a great suggestion, thank you !! I completely overlooked that code. What will happen to the legacy phy reset code in fec? Are there many users left?

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-15 Thread Andy Duan
From: Sven Van Asbroeck Sent: Tuesday, July 16, 2019 5:05 AM > The current fec driver allows the PHY to be reset via a gpio, specified in the > devicetree. However, some PHYs need to be reset in a more complex way. > > To accommodate such PHYs, allow an optional reset controller in the fec >

[PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-15 Thread Sven Van Asbroeck
The current fec driver allows the PHY to be reset via a gpio, specified in the devicetree. However, some PHYs need to be reset in a more complex way. To accommodate such PHYs, allow an optional reset controller in the fec devicetree. If no reset controller is found, the fec will fall back to the