Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, Apr 3, 2017 at 7:04 PM, Philipp Zabel wrote: > On Mon, 2017-04-03 at 18:23 +0300, Andy Shevchenko wrote: >> On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: >> > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: >> > > On Mon, 2017-04-03 at 17:31

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, Apr 3, 2017 at 7:04 PM, Philipp Zabel wrote: > On Mon, 2017-04-03 at 18:23 +0300, Andy Shevchenko wrote: >> On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: >> > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: >> > > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 18:23 +0300, Andy Shevchenko wrote: > On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: > > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > > > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > > > On Mon, 2017-04-03 at 16:27 +0200, Philipp

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 18:23 +0300, Andy Shevchenko wrote: > On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: > > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > > > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > > > On Mon, 2017-04-03 at 16:27 +0200, Philipp

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > > > > > >   int rstc_id; > > > > >  

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 17:09 +0200, Philipp Zabel wrote: > On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > > > > > >   int rstc_id; > > > > >  

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > > > > > int rstc_id; > > > > int ret; > > > > > > > > - if (!node) > > > > -

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 14:33 +, Shevchenko, Andriy wrote: > On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > > > > > int rstc_id; > > > > int ret; > > > > > > > > - if (!node) > > > > -

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > >   int rstc_id; > > >   int ret; > > >   > > > - if (!node) > > > - return ERR_PTR(-EINVAL); > > > - > > > > This should be > > > > if (!node) > >

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 17:31 +0300, Andy Shevchenko wrote: > On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > > > > >   int rstc_id; > > >   int ret; > > >   > > > - if (!node) > > > - return ERR_PTR(-EINVAL); > > > - > > > > This should be > > > > if (!node) > >

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > Hi Andy, > > thank you for the patch. > > On Mon, 2017-04-03 at 15:26 +0300, Andy Shevchenko wrote: > > There is Device Tree oriented check for optional resource. Of course > > it will fail on non-DT platforms. > > > > Remove this check

Re: [PATCH v1] reset: Make optional stuff optional for all users

On Mon, 2017-04-03 at 16:27 +0200, Philipp Zabel wrote: > Hi Andy, > > thank you for the patch. > > On Mon, 2017-04-03 at 15:26 +0300, Andy Shevchenko wrote: > > There is Device Tree oriented check for optional resource. Of course > > it will fail on non-DT platforms. > > > > Remove this check

Re: [PATCH v1] reset: Make optional stuff optional for all users

Hi Andy, thank you for the patch. On Mon, 2017-04-03 at 15:26 +0300, Andy Shevchenko wrote: > There is Device Tree oriented check for optional resource. Of course > it will fail on non-DT platforms. > > Remove this check to make things optional for all users. > > Fixes: bb475230b8e5 ("reset:

Re: [PATCH v1] reset: Make optional stuff optional for all users

Hi Andy, thank you for the patch. On Mon, 2017-04-03 at 15:26 +0300, Andy Shevchenko wrote: > There is Device Tree oriented check for optional resource. Of course > it will fail on non-DT platforms. > > Remove this check to make things optional for all users. > > Fixes: bb475230b8e5 ("reset:

[PATCH v1] reset: Make optional stuff optional for all users

There is Device Tree oriented check for optional resource. Of course it will fail on non-DT platforms. Remove this check to make things optional for all users. Fixes: bb475230b8e5 ("reset: make optional functions really optional") Cc: Ramiro Oliveira Signed-off-by:

[PATCH v1] reset: Make optional stuff optional for all users

There is Device Tree oriented check for optional resource. Of course it will fail on non-DT platforms. Remove this check to make things optional for all users. Fixes: bb475230b8e5 ("reset: make optional functions really optional") Cc: Ramiro Oliveira Signed-off-by: Andy Shevchenko --- The