Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-05-01 Thread Shuah Khan
On 04/30/2017 12:22 PM, Will Drewry wrote: > On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook wrote: >> >> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: >>> The seccomp/test_harness.h file contains useful helpers to build tests. >>> Moving it to the

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-05-01 Thread Shuah Khan
On 04/30/2017 12:22 PM, Will Drewry wrote: > On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook wrote: >> >> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: >>> The seccomp/test_harness.h file contains useful helpers to build tests. >>> Moving it to the selftest directory should benefit to other

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-05-01 Thread Mickaël Salaün
Maybe an update on the MAINTAINERS file could help for future reviews? diff --git a/MAINTAINERS b/MAINTAINERS index c265a5fe4848..0361364afb50 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11254,6 +11254,7 @@ F: kernel/seccomp.c F: include/uapi/linux/seccomp.h F:

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-05-01 Thread Mickaël Salaün
Maybe an update on the MAINTAINERS file could help for future reviews? diff --git a/MAINTAINERS b/MAINTAINERS index c265a5fe4848..0361364afb50 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11254,6 +11254,7 @@ F: kernel/seccomp.c F: include/uapi/linux/seccomp.h F:

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Will Drewry
On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook wrote: > > On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: > > The seccomp/test_harness.h file contains useful helpers to build tests. > > Moving it to the selftest directory should benefit to other test

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Will Drewry
On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook wrote: > > On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: > > The seccomp/test_harness.h file contains useful helpers to build tests. > > Moving it to the selftest directory should benefit to other test > > components. > > Unless Shuah thinks

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Kees Cook
On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: > The seccomp/test_harness.h file contains useful helpers to build tests. > Moving it to the selftest directory should benefit to other test > components. Unless Shuah thinks this should live in a new include/ directory,

Re: [PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Kees Cook
On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün wrote: > The seccomp/test_harness.h file contains useful helpers to build tests. > Moving it to the selftest directory should benefit to other test > components. Unless Shuah thinks this should live in a new include/ directory, this looks fine to

[PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Mickaël Salaün
The seccomp/test_harness.h file contains useful helpers to build tests. Moving it to the selftest directory should benefit to other test components. Signed-off-by: Mickaël Salaün Cc: Andy Lutomirski Cc: Kees Cook Cc: Shuah Khan

[PATCH v1] selftests: Make test_harness.h more generally available

2017-04-30 Thread Mickaël Salaün
The seccomp/test_harness.h file contains useful helpers to build tests. Moving it to the selftest directory should benefit to other test components. Signed-off-by: Mickaël Salaün Cc: Andy Lutomirski Cc: Kees Cook Cc: Shuah Khan Cc: Will Drewry Link: