Re: [PATCH v1 0/6] no-copy bvec

2020-12-24 Thread James Bottomley
On Wed, 2020-12-23 at 15:23 -0500, Douglas Gilbert wrote: > On 2020-12-23 11:04 a.m., James Bottomley wrote: > > On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: > > > On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote: > > > > Can scatterlist have 0-len entries? Those are

Re: [PATCH v1 0/6] no-copy bvec

2020-12-24 Thread Douglas Gilbert
On 2020-12-24 1:41 a.m., Christoph Hellwig wrote: On Wed, Dec 23, 2020 at 08:32:45PM +, Pavel Begunkov wrote: On 23/12/2020 20:23, Douglas Gilbert wrote: On 2020-12-23 11:04 a.m., James Bottomley wrote: On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: On Wed, Dec 23, 2020 at

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread Christoph Hellwig
On Wed, Dec 23, 2020 at 08:32:45PM +, Pavel Begunkov wrote: > On 23/12/2020 20:23, Douglas Gilbert wrote: > > On 2020-12-23 11:04 a.m., James Bottomley wrote: > >> On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: > >>> On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote:

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread Pavel Begunkov
On 23/12/2020 20:23, Douglas Gilbert wrote: > On 2020-12-23 11:04 a.m., James Bottomley wrote: >> On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: >>> On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote: Can scatterlist have 0-len entries? Those are directly translated

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread Douglas Gilbert
On 2020-12-23 11:04 a.m., James Bottomley wrote: On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote: Can scatterlist have 0-len entries? Those are directly translated into bvecs, e.g. in nvme/target/io-cmd-file.c and

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread James Bottomley
On Wed, 2020-12-23 at 15:51 +, Christoph Hellwig wrote: > On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote: > > Can scatterlist have 0-len entries? Those are directly translated > > into bvecs, e.g. in nvme/target/io-cmd-file.c and > > target/target_core_file.c. I've audited most

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread Christoph Hellwig
On Wed, Dec 23, 2020 at 12:52:59PM +, Pavel Begunkov wrote: > Can scatterlist have 0-len entries? Those are directly translated into > bvecs, e.g. in nvme/target/io-cmd-file.c and target/target_core_file.c. > I've audited most of others by this moment, they're fine. For block layer SGLs we

Re: [PATCH v1 0/6] no-copy bvec

2020-12-23 Thread Pavel Begunkov
On 22/12/2020 14:11, Christoph Hellwig wrote: > On Tue, Dec 15, 2020 at 02:05:35PM +, Pavel Begunkov wrote: >>> You may find clue from the following link: >>> >>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2262077.html >> >> Thanks for the link! >> >> Al, you mentioned

Re: [PATCH v1 0/6] no-copy bvec

2020-12-22 Thread Christoph Hellwig
On Tue, Dec 15, 2020 at 02:05:35PM +, Pavel Begunkov wrote: > > You may find clue from the following link: > > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2262077.html > > Thanks for the link! > > Al, you mentioned "Zero-length segments are not disallowed", do you have

Re: [PATCH v1 0/6] no-copy bvec

2020-12-15 Thread Pavel Begunkov
On 15/12/2020 12:03, Ming Lei wrote: > On Tue, Dec 15, 2020 at 11:14:20AM +, Pavel Begunkov wrote: >> On 15/12/2020 01:41, Ming Lei wrote: >>> On Tue, Dec 15, 2020 at 12:20:19AM +, Pavel Begunkov wrote: Instead of creating a full copy of iter->bvec into bio in direct I/O, the

Re: [PATCH v1 0/6] no-copy bvec

2020-12-15 Thread Ming Lei
On Tue, Dec 15, 2020 at 11:14:20AM +, Pavel Begunkov wrote: > On 15/12/2020 01:41, Ming Lei wrote: > > On Tue, Dec 15, 2020 at 12:20:19AM +, Pavel Begunkov wrote: > >> Instead of creating a full copy of iter->bvec into bio in direct I/O, > >> the patchset makes use of the one provided. It

Re: [PATCH v1 0/6] no-copy bvec

2020-12-15 Thread Pavel Begunkov
On 15/12/2020 01:41, Ming Lei wrote: > On Tue, Dec 15, 2020 at 12:20:19AM +, Pavel Begunkov wrote: >> Instead of creating a full copy of iter->bvec into bio in direct I/O, >> the patchset makes use of the one provided. It changes semantics and >> obliges users of asynchronous kiocb to track

Re: [PATCH v1 0/6] no-copy bvec

2020-12-14 Thread Ming Lei
On Tue, Dec 15, 2020 at 12:20:19AM +, Pavel Begunkov wrote: > Instead of creating a full copy of iter->bvec into bio in direct I/O, > the patchset makes use of the one provided. It changes semantics and > obliges users of asynchronous kiocb to track bvec lifetime, and [1/6] > converts the only

[PATCH v1 0/6] no-copy bvec

2020-12-14 Thread Pavel Begunkov
Instead of creating a full copy of iter->bvec into bio in direct I/O, the patchset makes use of the one provided. It changes semantics and obliges users of asynchronous kiocb to track bvec lifetime, and [1/6] converts the only place that doesn't. bio_iov_iter_get_pages() is still does