Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-07-04 Thread Duc Dang
On Mon, Jun 6, 2016 at 4:04 PM, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-07-04 Thread Duc Dang
On Mon, Jun 6, 2016 at 4:04 PM, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request resources for

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread wangyijing
在 2016/6/21 23:03, Bjorn Helgaas 写道: > On Tue, Jun 21, 2016 at 07:58:08PM +0800, wangyijing wrote: >> Hi Bjorn, use devm_request_resource() for host bridge resource is cool, >> what about do the similar change for x86, now we request host bridge resource >> in pci_acpi_root_add_resources() in

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread wangyijing
在 2016/6/21 23:03, Bjorn Helgaas 写道: > On Tue, Jun 21, 2016 at 07:58:08PM +0800, wangyijing wrote: >> Hi Bjorn, use devm_request_resource() for host bridge resource is cool, >> what about do the similar change for x86, now we request host bridge resource >> in pci_acpi_root_add_resources() in

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread Bjorn Helgaas
On Tue, Jun 21, 2016 at 07:58:08PM +0800, wangyijing wrote: > Hi Bjorn, use devm_request_resource() for host bridge resource is cool, > what about do the similar change for x86, now we request host bridge resource > in pci_acpi_root_add_resources() in x86, and we would release the host bridge >

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread Bjorn Helgaas
On Tue, Jun 21, 2016 at 07:58:08PM +0800, wangyijing wrote: > Hi Bjorn, use devm_request_resource() for host bridge resource is cool, > what about do the similar change for x86, now we request host bridge resource > in pci_acpi_root_add_resources() in x86, and we would release the host bridge >

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread wangyijing
Hi Bjorn, use devm_request_resource() for host bridge resource is cool, what about do the similar change for x86, now we request host bridge resource in pci_acpi_root_add_resources() in x86, and we would release the host bridge resource when host bridge device refcount reach 0. This logic may

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-21 Thread wangyijing
Hi Bjorn, use devm_request_resource() for host bridge resource is cool, what about do the similar change for x86, now we request host bridge resource in pci_acpi_root_add_resources() in x86, and we would release the host bridge resource when host bridge device refcount reach 0. This logic may

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-18 Thread Bjorn Helgaas
On Mon, Jun 06, 2016 at 06:04:44PM -0500, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-18 Thread Bjorn Helgaas
On Mon, Jun 06, 2016 at 06:04:44PM -0500, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-18 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 08:11:05AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 07, 2016 at 10:21:36AM +0200, Arnd Bergmann wrote: > > On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > > > Several host bridge drivers (designware and all derivatives, iproc, > > > xgene, xilinx, and

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-18 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 08:11:05AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 07, 2016 at 10:21:36AM +0200, Arnd Bergmann wrote: > > On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > > > Several host bridge drivers (designware and all derivatives, iproc, > > > xgene, xilinx, and

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-10 Thread Duc Dang
On Mon, Jun 6, 2016 at 4:04 PM, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-10 Thread Duc Dang
On Mon, Jun 6, 2016 at 4:04 PM, Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request resources for

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 03:25:46PM +0200, Arnd Bergmann wrote: > On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote: > > > > > > What do you think is the correct behavior here, should the driver only > > > request the PIO range with parent=ioport_resource, or should it also > > >

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 03:25:46PM +0200, Arnd Bergmann wrote: > On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote: > > > > > > What do you think is the correct behavior here, should the driver only > > > request the PIO range with parent=ioport_resource, or should it also > > >

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Arnd Bergmann
On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote: > > > > What do you think is the correct behavior here, should the driver only > > request the PIO range with parent=ioport_resource, or should it also > > request the MMIO window for the I/O ports with parent=iomem_resource? > > In

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Arnd Bergmann
On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote: > > > > What do you think is the correct behavior here, should the driver only > > request the PIO range with parent=ioport_resource, or should it also > > request the MMIO window for the I/O ports with parent=iomem_resource? > > In

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 10:21:36AM +0200, Arnd Bergmann wrote: > On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > > Several host bridge drivers (designware and all derivatives, iproc, > > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > > windows they forward

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Bjorn Helgaas
On Tue, Jun 07, 2016 at 10:21:36AM +0200, Arnd Bergmann wrote: > On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > > Several host bridge drivers (designware and all derivatives, iproc, > > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > > windows they forward

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Arnd Bergmann
On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request

Re: [PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-07 Thread Arnd Bergmann
On Monday, June 6, 2016 6:04:44 PM CEST Bjorn Helgaas wrote: > Several host bridge drivers (designware and all derivatives, iproc, > xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port > windows they forward downstream to the PCI bus. > > That means the PCI core can't request

[PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-06 Thread Bjorn Helgaas
Several host bridge drivers (designware and all derivatives, iproc, xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port windows they forward downstream to the PCI bus. That means the PCI core can't request resources for PCI bridge windows and PCI BARs. Several other drivers

[PATCH v1 00/25] PCI: Request host bridge window resources

2016-06-06 Thread Bjorn Helgaas
Several host bridge drivers (designware and all derivatives, iproc, xgene, xilinx, and xilinx-nwl) don't request the MMIO and I/O port windows they forward downstream to the PCI bus. That means the PCI core can't request resources for PCI bridge windows and PCI BARs. Several other drivers