On Wed, May 20, 2020 at 05:51:27AM -0700, Eric Dumazet wrote:
>
> On 5/19/20 11:42 PM, Ahmed S. Darwish wrote:
> > Hello Eric,
> >
> > On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote:
> >>
> >> On 5/19/20 2:45 PM, Ahmed S. Darwish wrote:
> >>> Sequence counters write paths are
On Wed, May 20, 2020 at 05:37:07PM +0300, Dan Carpenter wrote:
...
>
> smatch warnings:
> net/core/dev.c:953 netdev_get_name() warn: inconsistent returns
> 'devnet_rename_sem'.
>
...
>
> 5dbe7c178d3f0a4 Nicolas Schichan 2013-06-26 935 int netdev_get_name(struct
> net *net, char *name, int
On Wed, 20 May 2020 21:37:11 +0200
Thomas Gleixner wrote:
> David Miller writes:
> > From: Thomas Gleixner
> > Date: Wed, 20 May 2020 01:42:30 +0200
> >>> Please try, it isn't that hard..
> >>>
> >>> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done
> >>>
> >>> real
David Miller writes:
> From: Thomas Gleixner
> Date: Wed, 20 May 2020 01:42:30 +0200
>>> Please try, it isn't that hard..
>>>
>>> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done
>>>
>>> real0m17.002s
>>> user0m1.064s
>>> sys 0m0.375s
>>
>> And that
Hi "Ahmed,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/locking/core]
[also build test WARNING on nf-next/master nf/master tip/timers/core
linus/master v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to
On 5/19/20 11:42 PM, Ahmed S. Darwish wrote:
> Hello Eric,
>
> On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote:
>>
>> On 5/19/20 2:45 PM, Ahmed S. Darwish wrote:
>>> Sequence counters write paths are critical sections that must never be
>>> preempted, and blocking, even for
Hello Eric,
On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote:
>
> On 5/19/20 2:45 PM, Ahmed S. Darwish wrote:
> > Sequence counters write paths are critical sections that must never be
> > preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed.
> >
> > Commit
On Tue, 19 May 2020 20:18:19 -0700
Eric Dumazet wrote:
> On 5/19/20 7:57 PM, David Miller wrote:
> > From: Thomas Gleixner
> > Date: Wed, 20 May 2020 01:42:30 +0200
> >
> >> Stephen Hemminger writes:
> >>> On Wed, 20 May 2020 00:23:48 +0200
> >>> Thomas Gleixner wrote:
> No. We
On 5/19/20 7:57 PM, David Miller wrote:
> From: Thomas Gleixner
> Date: Wed, 20 May 2020 01:42:30 +0200
>
>> Stephen Hemminger writes:
>>> On Wed, 20 May 2020 00:23:48 +0200
>>> Thomas Gleixner wrote:
No. We did not. -ENOTESTCASE
>>>
>>> Please try, it isn't that hard..
>>>
>>> # time
From: Thomas Gleixner
Date: Wed, 20 May 2020 01:42:30 +0200
> Stephen Hemminger writes:
>> On Wed, 20 May 2020 00:23:48 +0200
>> Thomas Gleixner wrote:
>>> No. We did not. -ENOTESTCASE
>>
>> Please try, it isn't that hard..
>>
>> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type
On 5/19/20 2:45 PM, Ahmed S. Darwish wrote:
> Sequence counters write paths are critical sections that must never be
> preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed.
>
> Commit 5dbe7c178d3f ("net: fix kernel deadlock with interface rename and
> netdev name retrieval.")
Stephen Hemminger writes:
> On Wed, 20 May 2020 01:42:30 +0200
> Thomas Gleixner wrote:
>
>> Stephen Hemminger writes:
>> > On Wed, 20 May 2020 00:23:48 +0200
>> > Thomas Gleixner wrote:
>> >> No. We did not. -ENOTESTCASE
>> >
>> > Please try, it isn't that hard..
>> >
>> > # time for
On Wed, 20 May 2020 01:42:30 +0200
Thomas Gleixner wrote:
> Stephen Hemminger writes:
> > On Wed, 20 May 2020 00:23:48 +0200
> > Thomas Gleixner wrote:
> >> No. We did not. -ENOTESTCASE
> >
> > Please try, it isn't that hard..
> >
> > # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i
Stephen Hemminger writes:
> On Wed, 20 May 2020 00:23:48 +0200
> Thomas Gleixner wrote:
>> No. We did not. -ENOTESTCASE
>
> Please try, it isn't that hard..
>
> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done
>
> real 0m17.002s
> user 0m1.064s
> sys 0m0.375s
And
On Wed, 20 May 2020 00:23:48 +0200
Thomas Gleixner wrote:
> Stephen Hemminger writes:
> > On Tue, 19 May 2020 23:45:23 +0200
> > "Ahmed S. Darwish" wrote:
> >
> >> Sequence counters write paths are critical sections that must never be
> >> preempted, and blocking, even for
Stephen Hemminger writes:
> On Tue, 19 May 2020 23:45:23 +0200
> "Ahmed S. Darwish" wrote:
>
>> Sequence counters write paths are critical sections that must never be
>> preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed.
>>
>> Commit 5dbe7c178d3f ("net: fix kernel deadlock
On Tue, 19 May 2020 23:45:23 +0200
"Ahmed S. Darwish" wrote:
> Sequence counters write paths are critical sections that must never be
> preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed.
>
> Commit 5dbe7c178d3f ("net: fix kernel deadlock with interface rename and
> netdev
Sequence counters write paths are critical sections that must never be
preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed.
Commit 5dbe7c178d3f ("net: fix kernel deadlock with interface rename and
netdev name retrieval.") handled a deadlock, observed with
CONFIG_PREEMPTION=n,
18 matches
Mail list logo
