Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Thomas Gleixner
On Wed, 1 Oct 2014, dbasehore . wrote: > On Wed, Oct 1, 2014 at 3:30 PM, Rafael J. Wysocki wrote: Please stop top-posting and trim the quoted text. This is not your $corp mail drop. > dpm_resume_noirq is not early enough for the Xen stuff, but should be > early enough for other stuff. This

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Wednesday, October 01, 2014 04:01:33 PM dbasehore . wrote: > dpm_resume_noirq is not early enough for the Xen stuff, but should be > early enough for other stuff. This patch is mostly just a bandage on > top of the broken IRQF_EARLY_RESUME code. > > We may consider getting rid of

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread dbasehore .
dpm_resume_noirq is not early enough for the Xen stuff, but should be early enough for other stuff. This patch is mostly just a bandage on top of the broken IRQF_EARLY_RESUME code. We may consider getting rid of IRQF_EARLY_RESUME and having Xen register its own syscore resume function to enable

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Thursday, October 02, 2014 12:25:08 AM Rafael J. Wysocki wrote: > On Wednesday, October 01, 2014 01:48:39 PM dbasehore . wrote: > > Adding maintainers for affected systems to this CL for review. > > > > On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk > > wrote: > > > On Fri, Jun 27,

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Wednesday, October 01, 2014 01:48:39 PM dbasehore . wrote: > Adding maintainers for affected systems to this CL for review. > > On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk > wrote: > > On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: > >> In the case of a late abort

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread dbasehore .
Adding maintainers for affected systems to this CL for review. On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: >> In the case of a late abort to suspend/hibernate, irqs marked with >> IRQF_EARLY_RESUME will not be

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread dbasehore .
Adding maintainers for affected systems to this CL for review. On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: In the case of a late abort to suspend/hibernate, irqs marked with

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Wednesday, October 01, 2014 01:48:39 PM dbasehore . wrote: Adding maintainers for affected systems to this CL for review. On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: In the case of a

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Thursday, October 02, 2014 12:25:08 AM Rafael J. Wysocki wrote: On Wednesday, October 01, 2014 01:48:39 PM dbasehore . wrote: Adding maintainers for affected systems to this CL for review. On Mon, Jul 7, 2014 at 8:33 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri,

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread dbasehore .
dpm_resume_noirq is not early enough for the Xen stuff, but should be early enough for other stuff. This patch is mostly just a bandage on top of the broken IRQF_EARLY_RESUME code. We may consider getting rid of IRQF_EARLY_RESUME and having Xen register its own syscore resume function to enable

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Rafael J. Wysocki
On Wednesday, October 01, 2014 04:01:33 PM dbasehore . wrote: dpm_resume_noirq is not early enough for the Xen stuff, but should be early enough for other stuff. This patch is mostly just a bandage on top of the broken IRQF_EARLY_RESUME code. We may consider getting rid of IRQF_EARLY_RESUME

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-10-01 Thread Thomas Gleixner
On Wed, 1 Oct 2014, dbasehore . wrote: On Wed, Oct 1, 2014 at 3:30 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Please stop top-posting and trim the quoted text. This is not your $corp mail drop. dpm_resume_noirq is not early enough for the Xen stuff, but should be early enough for other

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-07-07 Thread Konrad Rzeszutek Wilk
On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: > In the case of a late abort to suspend/hibernate, irqs marked with > IRQF_EARLY_RESUME will not be enabled. This is due to syscore_resume not > getting > called on these paths. > > This can happen with a pm test for platform, a

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-07-07 Thread Konrad Rzeszutek Wilk
On Fri, Jun 27, 2014 at 05:04:24PM -0700, Derek Basehore wrote: In the case of a late abort to suspend/hibernate, irqs marked with IRQF_EARLY_RESUME will not be enabled. This is due to syscore_resume not getting called on these paths. This can happen with a pm test for platform, a late

[PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-06-27 Thread Derek Basehore
In the case of a late abort to suspend/hibernate, irqs marked with IRQF_EARLY_RESUME will not be enabled. This is due to syscore_resume not getting called on these paths. This can happen with a pm test for platform, a late wakeup irq, and other instances. This change removes the function from

[PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-06-27 Thread Derek Basehore
In the case of a late abort to suspend/hibernate, irqs marked with IRQF_EARLY_RESUME will not be enabled. This is due to syscore_resume not getting called on these paths. This can happen with a pm test for platform, a late wakeup irq, and other instances. This change removes the function from