Re: [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-11 Thread Asutosh Das (asd)
On 11/2/2020 10:24 PM, Can Guo wrote: The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be decreased back in ufshcd_ungate_work() in a paired way. However, if specific ufshcd_hold/release sequences are met, it is possible that scsi_block_reqs_cnt is increased twice but only one

RE: [EXT] [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-03 Thread Bean Huo (beanhuo)
> > Signed-off-by: Can Guo > Reviewed-by: Hongwu Su Reviewed-by: Bean Huo

Re: [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-03 Thread Stanley Chu
Hi Can, On Tue, 2020-11-03 at 18:01 +0800, Can Guo wrote: > On 2020-11-03 15:07, Stanley Chu wrote: > > Hi Can, > > > > On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: > >> The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be > >> decreased back in ufshcd_ungate_work() in a

Re: [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-03 Thread Can Guo
On 2020-11-03 15:07, Stanley Chu wrote: Hi Can, On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be decreased back in ufshcd_ungate_work() in a paired way. However, if specific ufshcd_hold/release sequences are met, it is

Re: [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-02 Thread Stanley Chu
Hi Can, On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: > The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be > decreased back in ufshcd_ungate_work() in a paired way. However, if > specific ufshcd_hold/release sequences are met, it is possible that > scsi_block_reqs_cnt is

[PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-02 Thread Can Guo
The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be decreased back in ufshcd_ungate_work() in a paired way. However, if specific ufshcd_hold/release sequences are met, it is possible that scsi_block_reqs_cnt is increased twice but only one ungate work is queued. To make sure