Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Sat, 6 Oct 2018, Andi Kleen wrote: > On Sat, Oct 06, 2018 at 04:14:54PM +0200, Thomas Gleixner wrote: > > On Fri, 5 Oct 2018, Andi Kleen wrote: > > > +/* > > > + * Match specific microcodes or steppings. > > > > What means microcodes or steppings? If you mean microcode revisions then > >

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Sat, 6 Oct 2018, Andi Kleen wrote: > On Sat, Oct 06, 2018 at 04:14:54PM +0200, Thomas Gleixner wrote: > > On Fri, 5 Oct 2018, Andi Kleen wrote: > > > +/* > > > + * Match specific microcodes or steppings. > > > > What means microcodes or steppings? If you mean microcode revisions then > >

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Borislav Petkov
On Sat, Oct 06, 2018 at 11:15:07AM -0700, Andi Kleen wrote: > The matcher can be used to match specific hardware steppings by setting > the min/max_ucode to 0 or specific microcode revisions > (which are associated with steppings) This better be explained unambiguously. > We still support the

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Borislav Petkov
On Sat, Oct 06, 2018 at 11:15:07AM -0700, Andi Kleen wrote: > The matcher can be used to match specific hardware steppings by setting > the min/max_ucode to 0 or specific microcode revisions > (which are associated with steppings) This better be explained unambiguously. > We still support the

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Andi Kleen
On Sat, Oct 06, 2018 at 04:14:54PM +0200, Thomas Gleixner wrote: > On Fri, 5 Oct 2018, Andi Kleen wrote: > > +/* > > + * Match specific microcodes or steppings. > > What means microcodes or steppings? If you mean microcode revisions then > please spell it out and use it all over the place.

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Andi Kleen
On Sat, Oct 06, 2018 at 04:14:54PM +0200, Thomas Gleixner wrote: > On Fri, 5 Oct 2018, Andi Kleen wrote: > > +/* > > + * Match specific microcodes or steppings. > > What means microcodes or steppings? If you mean microcode revisions then > please spell it out and use it all over the place.

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Sat, 6 Oct 2018, Thomas Gleixner wrote: > On Fri, 5 Oct 2018, Andi Kleen wrote: > > +/* > > + * Match specific microcodes or steppings. > > What means microcodes or steppings? If you mean microcode revisions then > please spell it out and use it all over the place. steppings is confusing > at

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Sat, 6 Oct 2018, Thomas Gleixner wrote: > On Fri, 5 Oct 2018, Andi Kleen wrote: > > +/* > > + * Match specific microcodes or steppings. > > What means microcodes or steppings? If you mean microcode revisions then > please spell it out and use it all over the place. steppings is confusing > at

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Fri, 5 Oct 2018, Andi Kleen wrote: > +/* > + * Match specific microcodes or steppings. What means microcodes or steppings? If you mean microcode revisions then please spell it out and use it all over the place. steppings is confusing at best as its associated to the CPU stepping. > + * > + *

Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-06 Thread Thomas Gleixner
On Fri, 5 Oct 2018, Andi Kleen wrote: > +/* > + * Match specific microcodes or steppings. What means microcodes or steppings? If you mean microcode revisions then please spell it out and use it all over the place. steppings is confusing at best as its associated to the CPU stepping. > + * > + *

[PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-05 Thread Andi Kleen
From: Andi Kleen For bug workarounds or checks it is useful to check for specific microcode versions. Add a new table format to check for steppings with min/max microcode revisions. This does not change the existing x86_cpu_id because it's an ABI shared with modutils, and also has quite

[PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-05 Thread Andi Kleen
From: Andi Kleen For bug workarounds or checks it is useful to check for specific microcode versions. Add a new table format to check for steppings with min/max microcode revisions. This does not change the existing x86_cpu_id because it's an ABI shared with modutils, and also has quite