Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
Well, I will think about it and I will propose a separated patch with a generic property and helper functions. 2014-09-28 15:25 GMT+02:00 PERIER Romain : > 2014-09-28 14:25 GMT+02:00 Mark Brown : >> On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote: >>> 2014-09-28 12:33 GMT+02:00 Mark

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
2014-09-28 14:25 GMT+02:00 Mark Brown : > On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote: >> 2014-09-28 12:33 GMT+02:00 Mark Brown : > >> > We really need to come up with a standard property for this and document >> > it rather than continuing to add individual device specific

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread Mark Brown
On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote: > 2014-09-28 12:33 GMT+02:00 Mark Brown : > > We really need to come up with a standard property for this and document > > it rather than continuing to add individual device specific properties > > all doing the same thing, and

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
Hi Mark, 2014-09-28 12:33 GMT+02:00 Mark Brown : > On Sat, Sep 27, 2014 at 04:21:44PM +, Romain Perier wrote: >> When the property "active-semi,system-power-controller" is found in the >> devicetree, the function pm_power_off is defined. This function sends the >> rights bit fields to the

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread Mark Brown
On Sat, Sep 27, 2014 at 04:21:44PM +, Romain Perier wrote: > When the property "active-semi,system-power-controller" is found in the > devicetree, the function pm_power_off is defined. This function sends the > rights bit fields to the global off control register. shutdown/poweroff > commands

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread Mark Brown
On Sat, Sep 27, 2014 at 04:21:44PM +, Romain Perier wrote: When the property active-semi,system-power-controller is found in the devicetree, the function pm_power_off is defined. This function sends the rights bit fields to the global off control register. shutdown/poweroff commands are

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
Hi Mark, 2014-09-28 12:33 GMT+02:00 Mark Brown broo...@kernel.org: On Sat, Sep 27, 2014 at 04:21:44PM +, Romain Perier wrote: When the property active-semi,system-power-controller is found in the devicetree, the function pm_power_off is defined. This function sends the rights bit fields

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread Mark Brown
On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote: 2014-09-28 12:33 GMT+02:00 Mark Brown broo...@kernel.org: We really need to come up with a standard property for this and document it rather than continuing to add individual device specific properties all doing the same thing,

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
2014-09-28 14:25 GMT+02:00 Mark Brown broo...@kernel.org: On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote: 2014-09-28 12:33 GMT+02:00 Mark Brown broo...@kernel.org: We really need to come up with a standard property for this and document it rather than continuing to add

Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-28 Thread PERIER Romain
Well, I will think about it and I will propose a separated patch with a generic property and helper functions. 2014-09-28 15:25 GMT+02:00 PERIER Romain romain.per...@gmail.com: 2014-09-28 14:25 GMT+02:00 Mark Brown broo...@kernel.org: On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain

[PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-27 Thread Romain Perier
When the property "active-semi,system-power-controller" is found in the devicetree, the function pm_power_off is defined. This function sends the rights bit fields to the global off control register. shutdown/poweroff commands are now supported for hardware components which use these PMU.

[PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

2014-09-27 Thread Romain Perier
When the property active-semi,system-power-controller is found in the devicetree, the function pm_power_off is defined. This function sends the rights bit fields to the global off control register. shutdown/poweroff commands are now supported for hardware components which use these PMU.