Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

2018-01-11 Thread Andy Shevchenko
On Thu, 2018-01-11 at 15:07 +0300, Yury Norov wrote: > On Wed, Jan 10, 2018 at 03:11:45PM +0200, Andy Shevchenko wrote: > > On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote: > > > > > > I don't understand what patch #4 is doing in this series. At the > > > first > > > glance, it may be applied

Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

2018-01-11 Thread Yury Norov
On Wed, Jan 10, 2018 at 03:11:45PM +0200, Andy Shevchenko wrote: > On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote: > > Hi Andy, > > > > On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote: > > > Explicitly test bitmap_zero() and bitmap_clear() functions. > > > > + /* Known way to

Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

2018-01-10 Thread Andy Shevchenko
On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote: > Hi Andy, > > On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote: > > Explicitly test bitmap_zero() and bitmap_clear() functions. > > + /* Known way to set all bits */ > > Nit: if you start your comments with capital, proceed t

Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

2018-01-10 Thread Yury Norov
Hi Andy, On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote: > Explicitly test bitmap_zero() and bitmap_clear() functions. > > Signed-off-by: Andy Shevchenko > --- > lib/test_bitmap.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/lib/test

[PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

2018-01-09 Thread Andy Shevchenko
Explicitly test bitmap_zero() and bitmap_clear() functions. Signed-off-by: Andy Shevchenko --- lib/test_bitmap.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index de7ef2996a07..9734af711816 100644 --- a/lib/test_bitmap