Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-18 Thread Saravana Kannan
On Tue, Jun 18, 2019 at 1:47 PM Sandeep Patil wrote: > > On Wed, Jun 12, 2019 at 12:29:18PM -0700, 'Saravana Kannan' via kernel-team > wrote: > > On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: > > > > > > On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-18 Thread Sandeep Patil
On Wed, Jun 12, 2019 at 12:29:18PM -0700, 'Saravana Kannan' via kernel-team wrote: > On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: > > > > On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: > > > > On

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-13 Thread Saravana Kannan
On Wed, Jun 12, 2019 at 2:12 PM Rob Herring wrote: > > On Wed, Jun 12, 2019 at 1:29 PM Saravana Kannan wrote: > > > > On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: > > > > > > On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Wed, Jun 12, 2019 at

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Rob Herring
On Wed, Jun 12, 2019 at 1:29 PM Saravana Kannan wrote: > > On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: > > > > On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: > > > > On Wed, Jun 12, 2019 at 8:22 AM

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Frank Rowand
On 6/12/19 12:29 PM, Saravana Kannan wrote: > On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: >> >> On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman >> wrote: >>> >>> On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: On Wed, Jun 12, 2019 at 8:22 AM Greg Kroah-Hartman

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Saravana Kannan
On Wed, Jun 12, 2019 at 11:19 AM Rob Herring wrote: > > On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: > > > On Wed, Jun 12, 2019 at 8:22 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Wed, Jun 12, 2019 at

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Frank Rowand
On 6/12/19 6:53 AM, Rob Herring wrote: > On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: >> >> On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team >> wrote: >>> On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote: Hi Saravana, On 6/10/19 10:36 AM,

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Rob Herring
On Wed, Jun 12, 2019 at 11:08 AM Greg Kroah-Hartman wrote: > > On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: > > On Wed, Jun 12, 2019 at 8:22 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Jun 12, 2019 at 07:53:39AM -0600, Rob Herring wrote: > > > > On Tue, Jun 11, 2019 at

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Greg Kroah-Hartman
On Wed, Jun 12, 2019 at 10:53:09AM -0600, Rob Herring wrote: > On Wed, Jun 12, 2019 at 8:22 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jun 12, 2019 at 07:53:39AM -0600, Rob Herring wrote: > > > On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: > > > > > > > > On Tue, Jun 11, 2019 at

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Frank Rowand
On 6/12/19 7:21 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 12, 2019 at 07:53:39AM -0600, Rob Herring wrote: >> On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: >>> >>> On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team >>> wrote: On Tue, Jun 11, 2019 at 8:18 AM

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Rob Herring
On Wed, Jun 12, 2019 at 8:22 AM Greg Kroah-Hartman wrote: > > On Wed, Jun 12, 2019 at 07:53:39AM -0600, Rob Herring wrote: > > On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: > > > > > > On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via > > > kernel-team wrote: > > > > On

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Frank Rowand
On 6/12/19 9:07 AM, Frank Rowand wrote: > On 6/12/19 6:53 AM, Rob Herring wrote: >> On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: >>> >>> On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team >>> wrote: On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote:

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Frank Rowand
On 6/12/19 6:53 AM, Rob Herring wrote: > On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: >> >> On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team >> wrote: >>> On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote: Hi Saravana, On 6/10/19 10:36 AM,

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Greg Kroah-Hartman
On Wed, Jun 12, 2019 at 07:53:39AM -0600, Rob Herring wrote: > On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: > > > > On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team > > wrote: > > > On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand > > > wrote: > > > > > > > > Hi

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-12 Thread Rob Herring
On Tue, Jun 11, 2019 at 3:52 PM Sandeep Patil wrote: > > On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team > wrote: > > On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote: > > > > > > Hi Saravana, > > > > > > On 6/10/19 10:36 AM, Rob Herring wrote: > > > > Why are you

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-11 Thread Sandeep Patil
On Tue, Jun 11, 2019 at 01:56:25PM -0700, 'Saravana Kannan' via kernel-team wrote: > On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote: > > > > Hi Saravana, > > > > On 6/10/19 10:36 AM, Rob Herring wrote: > > > Why are you resending this rather than replying to Frank's last > > > comments on

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-11 Thread Saravana Kannan
On Tue, Jun 11, 2019 at 8:18 AM Frank Rowand wrote: > > Hi Saravana, > > On 6/10/19 10:36 AM, Rob Herring wrote: > > Why are you resending this rather than replying to Frank's last > > comments on the original? > > Adding on a different aspect... The independent replies from three different >

Re: [PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-11 Thread Saravana Kannan
On Tue, Jun 11, 2019 at 7:51 AM Frank Rowand wrote: > > Hi Saravana, > > (I notice that I never seem to spell your name correctly. Apologies for that, > both past and future). Thanks for noticing :) One trick that might help with remembering my name is that every other letter is an "a" :) > >

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-11 Thread Frank Rowand
Hi Saravana, On 6/10/19 10:36 AM, Rob Herring wrote: > Why are you resending this rather than replying to Frank's last > comments on the original? Adding on a different aspect... The independent replies from three different maintainers (Rob, Mark, myself) pointed out architectural issues with

Re: [PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-11 Thread Frank Rowand
Hi Saravana, (I notice that I never seem to spell your name correctly. Apologies for that, both past and future). This email was never answered. -Frank On 5/24/19 5:12 PM, Frank Rowand wrote: > On 5/24/19 11:21 AM, Saravana Kannan wrote: >> On Fri, May 24, 2019 at 10:56 AM Frank Rowand

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-10 Thread Rob Herring
On Mon, Jun 10, 2019 at 1:15 PM Saravana Kannan wrote: > > I did. And I didn't get a response. Folks suggested this might be one of the > preferred ways instead of sending "bump" emails. It's summer time and people go on vacation. Rob

Re: [RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-10 Thread Rob Herring
Why are you resending this rather than replying to Frank's last comments on the original? On Mon, Jun 3, 2019 at 6:32 PM Saravana Kannan wrote: > > Add a pointer from device tree node to the device created from it. > This allows us to find the device corresponding to a device tree node > without

[RESEND PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-06-03 Thread Saravana Kannan
Add a pointer from device tree node to the device created from it. This allows us to find the device corresponding to a device tree node without having to loop through all the platform devices. However, fallback to looping through the platform devices to handle any devices that might set their

Re: [PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-05-24 Thread Frank Rowand
On 5/24/19 11:21 AM, Saravana Kannan wrote: > On Fri, May 24, 2019 at 10:56 AM Frank Rowand wrote: >> >> Hi Sarvana, >> >> I'm not reviewing patches 1-5 in any detail, given my reply to patch 0. >> >> But I had already skimmed through this patch before I received the >> email for patch 0, so I

Re: [PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-05-24 Thread Saravana Kannan
On Fri, May 24, 2019 at 10:56 AM Frank Rowand wrote: > > Hi Sarvana, > > I'm not reviewing patches 1-5 in any detail, given my reply to patch 0. > > But I had already skimmed through this patch before I received the > email for patch 0, so I want to make one generic comment below, > to give some

Re: [PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-05-24 Thread Frank Rowand
Hi Sarvana, I'm not reviewing patches 1-5 in any detail, given my reply to patch 0. But I had already skimmed through this patch before I received the email for patch 0, so I want to make one generic comment below, to give some feedback as you continue thinking through possible implementations

[PATCH v1 1/5] of/platform: Speed up of_find_device_by_node()

2019-05-23 Thread Saravana Kannan
Add a pointer from device tree node to the device created from it. This allows us to find the device corresponding to a device tree node without having to loop through all the platform devices. However, fallback to looping through the platform devices to handle any devices that might set their