Re: [PATCH v1 2/2] scsi: ufs: Try to save power mode change and UIC cmd completion timeout

2020-11-03 Thread Stanley Chu
Hi Can, On Tue, 2020-11-03 at 16:01 +0800, Can Guo wrote: > Hi Stanley, > > On 2020-11-03 15:20, Stanley Chu wrote: > > Hi Can, > > > > Except for below nit, otherwise looks good to me. > > > > Reviewed-by: Stanley Chu > > > > On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: > >> Use the uic

Re: [PATCH v1 2/2] scsi: ufs: Try to save power mode change and UIC cmd completion timeout

2020-11-03 Thread Can Guo
Hi Stanley, On 2020-11-03 15:20, Stanley Chu wrote: Hi Can, Except for below nit, otherwise looks good to me. Reviewed-by: Stanley Chu On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: Use the uic_cmd->cmd_active as a flag to track the lifecycle of an UIC cmd. The flag is set before send th

Re: [PATCH v1 2/2] scsi: ufs: Try to save power mode change and UIC cmd completion timeout

2020-11-02 Thread Stanley Chu
Hi Can, Except for below nit, otherwise looks good to me. Reviewed-by: Stanley Chu On Mon, 2020-11-02 at 22:24 -0800, Can Guo wrote: > Use the uic_cmd->cmd_active as a flag to track the lifecycle of an UIC cmd. > The flag is set before send the UIC cmd and cleared in IRQ handler. When a > PMC o

[PATCH v1 2/2] scsi: ufs: Try to save power mode change and UIC cmd completion timeout

2020-11-02 Thread Can Guo
Use the uic_cmd->cmd_active as a flag to track the lifecycle of an UIC cmd. The flag is set before send the UIC cmd and cleared in IRQ handler. When a PMC or UIC cmd completion timeout happens, if the flag is not set, instead of returning timeout error, we still treat it as a successful operation.