Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, 2018-02-28 at 20:21 +0100, Jean Delvare wrote: > On Wed, 28 Feb 2018 11:33:39 +0100, Rafael J. Wysocki wrote: > > On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko > > wrote: > > > I would assume that no BIOS date is related to prehistoric > > >

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, 2018-02-28 at 20:21 +0100, Jean Delvare wrote: > On Wed, 28 Feb 2018 11:33:39 +0100, Rafael J. Wysocki wrote: > > On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko > > wrote: > > > I would assume that no BIOS date is related to prehistoric > > > firmwares and > > > using _CRS would sound

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, 28 Feb 2018 11:33:39 +0100, Rafael J. Wysocki wrote: > On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko > wrote: > > I would assume that no BIOS date is related to prehistoric firmwares and > > using _CRS would sound weird on them. > > Careful here.

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, 28 Feb 2018 11:33:39 +0100, Rafael J. Wysocki wrote: > On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko > wrote: > > I would assume that no BIOS date is related to prehistoric firmwares and > > using _CRS would sound weird on them. > > Careful here. > > You seem to be assuming that

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko wrote: > On Mon, 2018-02-26 at 17:28 +0100, Jean Delvare wrote: > >> > - if (dmi_get_date(DMI_BIOS_DATE, , NULL, NULL) && year >> > < 2008) { >> > - if (iomem_resource.end <= 0x) >> > -

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko wrote: > On Mon, 2018-02-26 at 17:28 +0100, Jean Delvare wrote: > >> > - if (dmi_get_date(DMI_BIOS_DATE, , NULL, NULL) && year >> > < 2008) { >> > - if (iomem_resource.end <= 0x) >> > - pci_use_crs = false; >>

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Mon, 2018-02-26 at 17:28 +0100, Jean Delvare wrote: > > - if (dmi_get_date(DMI_BIOS_DATE, , NULL, NULL) && year > > < 2008) { > > - if (iomem_resource.end <= 0x) > > - pci_use_crs = false; > > - } > > + if ((dmi_get_bios_year() < 2008) &&

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

On Mon, 2018-02-26 at 17:28 +0100, Jean Delvare wrote: > > - if (dmi_get_date(DMI_BIOS_DATE, , NULL, NULL) && year > > < 2008) { > > - if (iomem_resource.end <= 0x) > > - pci_use_crs = false; > > - } > > + if ((dmi_get_bios_year() < 2008) &&

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

Hi Andy, On Thu, 22 Feb 2018 14:59:21 +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/pci/acpi.c| 8 ++-- > arch/x86/pci/direct.c | 5 ++--- >

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

Hi Andy, On Thu, 22 Feb 2018 14:59:21 +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/pci/acpi.c| 8 ++-- > arch/x86/pci/direct.c | 5 ++--- > arch/x86/pci/mmconfig-shared.c | 9 ++---

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

x86/PCI: Re-use ... would match the arch/x86/pci/* convention. On Thu, Feb 22, 2018 at 02:59:21PM +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. And I personally like it when changelogs are complete in themselves, i.e., they aren't a continuation of the subject

Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

x86/PCI: Re-use ... would match the arch/x86/pci/* convention. On Thu, Feb 22, 2018 at 02:59:21PM +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. And I personally like it when changelogs are complete in themselves, i.e., they aren't a continuation of the subject

[PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

...instead of open coding its functionality. Signed-off-by: Andy Shevchenko --- arch/x86/pci/acpi.c| 8 ++-- arch/x86/pci/direct.c | 5 ++--- arch/x86/pci/mmconfig-shared.c | 9 ++--- 3 files changed, 6 insertions(+), 16

[PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper

...instead of open coding its functionality. Signed-off-by: Andy Shevchenko --- arch/x86/pci/acpi.c| 8 ++-- arch/x86/pci/direct.c | 5 ++--- arch/x86/pci/mmconfig-shared.c | 9 ++--- 3 files changed, 6 insertions(+), 16 deletions(-) diff --git