Re: [PATCH v1 2/7] PCI: Convert __pci_read_base() to __pci_bus_read_base()

2021-03-10 Thread Christoph Hellwig
> +static inline > int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, > + struct resource *res, unsigned int reg) This looks weird. Normal kernel style would be: static inline int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, struct

[PATCH v1 2/7] PCI: Convert __pci_read_base() to __pci_bus_read_base()

2021-03-08 Thread Andy Shevchenko
Some drivers would like to read PCI BAR of the devices which has been not or can't be enumerated. In particular such mechanism is required to read PCI BAR of hidden devices behind Primary to Sideband (P2SB) bridge. Refactor __pci_read_base() to provide __pci_bus_read_base() and represent the