Re: [PATCH v1 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-07-15 Thread Sowjanya Komatineni
On 7/15/20 10:46 AM, Luca Ceresoli wrote: Hi Sowjanya, your patch looks good, but I have a few comments about the coding style, see below. Thanks Luca. Will consider them for v2. On 15/07/20 06:24, Sowjanya Komatineni wrote: IMX274 has VANA analog 2.8V supply, VDIG digital core 1.8V

Re: [PATCH v1 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-07-15 Thread Luca Ceresoli
Hi Sowjanya, your patch looks good, but I have a few comments about the coding style, see below. On 15/07/20 06:24, Sowjanya Komatineni wrote: > IMX274 has VANA analog 2.8V supply, VDIG digital core 1.8V supply, > and VDDL digital io 1.2V supply which are optional based on camera > module

[PATCH v1 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-07-14 Thread Sowjanya Komatineni
IMX274 has VANA analog 2.8V supply, VDIG digital core 1.8V supply, and VDDL digital io 1.2V supply which are optional based on camera module design. IMX274 also need external 24Mhz clock and is optional based on camera module design. This patch adds support for IMX274 power on and off to enable