Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-20 Thread Vinod Koul
On Thu, Aug 20, 2015 at 12:31:44PM +0530, Rameshwar Sahu wrote: > Hi Vinod, > > On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul wrote: > > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: > >> + nents = sg_nents(req->src); > >> + sg_count = dma_map_sg(dev, req->src, nen

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-20 Thread Rameshwar Sahu
Hi Vinod, On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul wrote: > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: >> + nents = sg_nents(req->src); >> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE); >> + if (!sg_count) { >> + dev_err(dev,

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-19 Thread Vinod Koul
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: > + nents = sg_nents(req->src); > + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE); > + if (!sg_count) { > + dev_err(dev, "Failed to map src sg"); > + return -ENOMEM; mapping error

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-07-31 Thread Rameshwar Sahu
On Fri, Jul 31, 2015 at 12:43 PM, Herbert Xu wrote: > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: >> >> + .cra_name = "xgene(crc32c)", >> + .cra_driver_name= "crc32c-xgene", > > This looks wrong. If you're implementing crc32

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-07-31 Thread Herbert Xu
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: > > + .cra_name = "xgene(crc32c)", > + .cra_driver_name= "crc32c-xgene", This looks wrong. If you're implementing crc32c then cra_name should be just crc32c, i.e., the name of the

[PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-07-30 Thread Rameshwar Prasad Sahu
This patch implements support for APM X-Gene SoC CRC32C h/w accelerator. DMA engine in APM X-Gene SoC is capable of doing CRC32C calculations. Signed-off-by: Rameshwar Prasad Sahu --- drivers/crypto/Kconfig| 8 ++ drivers/crypto/Makefile | 1 + drivers/crypto/xgene-crc32c.c | 2