Re: [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal

2019-04-17 Thread Christian Brauner
On April 17, 2019 5:20:55 PM GMT+02:00, Oleg Nesterov wrote: >On 04/17, Christian Brauner wrote: >> >> On Wed, Apr 17, 2019 at 04:01:06PM +0200, Oleg Nesterov wrote: >> > On 04/16, Christian Brauner wrote: >> > > >> > > @@ -3581,12 +3588,12 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, >pidfd, int,

Re: [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal

2019-04-17 Thread Oleg Nesterov
On 04/17, Christian Brauner wrote: > > On Wed, Apr 17, 2019 at 04:01:06PM +0200, Oleg Nesterov wrote: > > On 04/16, Christian Brauner wrote: > > > > > > @@ -3581,12 +3588,12 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, pidfd, > > > int, sig, > > > if (flags) > > > return -EINVAL; > > >

Re: [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal

2019-04-17 Thread Christian Brauner
On Wed, Apr 17, 2019 at 04:01:06PM +0200, Oleg Nesterov wrote: > On 04/16, Christian Brauner wrote: > > > > @@ -3581,12 +3588,12 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, pidfd, int, > > sig, > > if (flags) > > return -EINVAL; > > > > - f = fdget_raw(pidfd); > > + f =

Re: [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal

2019-04-17 Thread Oleg Nesterov
On 04/16, Christian Brauner wrote: > > @@ -3581,12 +3588,12 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, pidfd, int, > sig, > if (flags) > return -EINVAL; > > - f = fdget_raw(pidfd); > + f = fdget(pidfd); could you explain this change? I am just curious, I don't

[PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal

2019-04-16 Thread Christian Brauner
Let pidfd_send_signal() use pidfds retrieved via CLONE_PIDFD. With this patch pidfd_send_signal() becomes independent of procfs. This fullfils the request made when we merged the pidfd_send_signal() patchset. The pidfd_send_signal() syscall is now always available allowing for it to be used by