Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-24 Thread Dmitry Osipenko
24.08.2020 01:30, Pavel Machek пишет: >> +orange_led->cdev.name = "power-button-orange"; > > "orange:power" -- or what is this LED usually used for? The orange LED is supposed to indicate that battery is charging up.

Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-24 Thread Dmitry Osipenko
24.08.2020 01:34, Pavel Machek пишет: > On Sun 2020-08-23 17:08:43, Dmitry Osipenko wrote: >> Acer Iconia Tab A500 is an Android tablet device which has two LEDs >> embedded into the Power Button. Orange LED indicates "battery charging" >> status and white LED indicates "wake-up/charge-done" status

Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-24 Thread Dmitry Osipenko
24.08.2020 01:30, Pavel Machek пишет: > Hi! Hello, Pavel! Thank you very much for the review! I'll take into account yours comments in the v2! >> Acer Iconia Tab A500 is an Android tablet device which has two LEDs >> embedded into the Power Button. Orange LED indicates "battery charging" >> statu

Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-23 Thread Pavel Machek
On Sun 2020-08-23 17:08:43, Dmitry Osipenko wrote: > Acer Iconia Tab A500 is an Android tablet device which has two LEDs > embedded into the Power Button. Orange LED indicates "battery charging" > status and white LED indicates "wake-up/charge-done" status. The new LED > driver provides control ove

Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-23 Thread Pavel Machek
Hi! > Acer Iconia Tab A500 is an Android tablet device which has two LEDs > embedded into the Power Button. Orange LED indicates "battery charging" > status and white LED indicates "wake-up/charge-done" status. The new LED > driver provides control over both LEDs to userspace. > @@ -0,0 +1,121 @@

[PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

2020-08-23 Thread Dmitry Osipenko
Acer Iconia Tab A500 is an Android tablet device which has two LEDs embedded into the Power Button. Orange LED indicates "battery charging" status and white LED indicates "wake-up/charge-done" status. The new LED driver provides control over both LEDs to userspace. Signed-off-by: Dmitry Osipenko