Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: > This patch modifies the functions that need to be passed the explicit > command to use a boolean flag. This way we can reuse the code for 64bit > compat commands. > I don't understand this at all. cmd seems like it should

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand this at all. cmd seems like it should be

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand

[PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-04 Thread Serban Constantinescu
This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 35 ++- 1 file changed, 18

[PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-04 Thread Serban Constantinescu
This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 35