RE: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-04-13 Thread Vadim Pasternak
r-...@vger.kernel.org; j...@resnulli.us; > Michael Shych <michae...@mellanox.com>; ivec...@redhat.com > Subject: Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to > mlx-platform > > On Tue, Mar 27, 2018 at 10:02:04AM +, Vadim Pasternak wrote: >

RE: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-04-13 Thread Vadim Pasternak
; j...@resnulli.us; > Michael Shych ; ivec...@redhat.com > Subject: Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to > mlx-platform > > On Tue, Mar 27, 2018 at 10:02:04AM +, Vadim Pasternak wrote: > > Patch adds new ODM systems, matched according to DMI_BOARD_NA

Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-04-13 Thread Darren Hart
On Tue, Mar 27, 2018 at 10:02:04AM +, Vadim Pasternak wrote: > Patch adds new ODM systems, matched according to DMI_BOARD_NAME. General nit. When writing your messages, please use the imperative (command) form. Rather than: "Patch adds" or "It changes" use the same form you use in the

Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-04-13 Thread Darren Hart
On Tue, Mar 27, 2018 at 10:02:04AM +, Vadim Pasternak wrote: > Patch adds new ODM systems, matched according to DMI_BOARD_NAME. General nit. When writing your messages, please use the imperative (command) form. Rather than: "Patch adds" or "It changes" use the same form you use in the

[PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-03-27 Thread Vadim Pasternak
Patch adds new ODM systems, matched according to DMI_BOARD_NAME. The supported ODM Ids are: VMOD0001, VMOD0002, VMOD0003, VMOD0004, VMOD0005. It doesn't introduce new systems, but allows to ODM companies to set DMI_BOARD_VENDOR and DMI_PRODUCT_NAME on their own. It assumes that ODM company can't

[PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-03-27 Thread Vadim Pasternak
Patch adds new ODM systems, matched according to DMI_BOARD_NAME. The supported ODM Ids are: VMOD0001, VMOD0002, VMOD0003, VMOD0004, VMOD0005. It doesn't introduce new systems, but allows to ODM companies to set DMI_BOARD_VENDOR and DMI_PRODUCT_NAME on their own. It assumes that ODM company can't