On Fri, 20 Nov 2020 13:59:07 +0100 Oleksij Rempel wrote:
> On Mon, Nov 16, 2020 at 04:28:44PM -0800, Jakub Kicinski wrote:
> > On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote:
> > > On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote:
> > > > For a while now we have been
On Mon, Nov 16, 2020 at 04:28:44PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote:
> > On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote:
> > > For a while now we have been pushing back on stats which have a proper
> > > interface to be added
On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote:
> On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote:
> > For a while now we have been pushing back on stats which have a proper
> > interface to be added to ethtool -S. So I'd expect the list of stats
> > exposed via ethtool
On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote:
> For a while now we have been pushing back on stats which have a proper
> interface to be added to ethtool -S. So I'd expect the list of stats
> exposed via ethtool will end up being shorter than in this patch.
Hmm, not sure if
On Mon, 16 Nov 2020 15:30:39 -0800 Florian Fainelli wrote:
> > What about RMON/RFC2819 style etherStatsPkts65to127Octets? We have a
> > number of switches supporting that style of counters, including the one
> > that Oleksij is adding support for, apparently (but not all switches
> > though). I
On Tue, 17 Nov 2020 01:27:31 +0200 Vladimir Oltean wrote:
> > Note that I said _forwarded_. Frames are either forwarded by the HW or
> > SW (former never hit the CPU, while the latter do hit the CPU or
> > originate from it).
>
> Ah, you were just thinking out loud, I really did not understand
On 11/16/20 3:27 PM, Vladimir Oltean wrote:
> On Mon, Nov 16, 2020 at 03:13:47PM -0800, Jakub Kicinski wrote:
>> On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote:
>>> On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote:
On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean
On Mon, Nov 16, 2020 at 03:13:47PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote:
> > On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote:
> > > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote:
> > > > On Mon, Nov 16, 2020 at 01:34:53PM
On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote:
> On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote:
> > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote:
> > > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote:
> > > > You must expose relevant
On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote:
> > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote:
> > > You must expose relevant statistics via the normal get_stats64 NDO
> > > before you start dumping
On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote:
> On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote:
> > You must expose relevant statistics via the normal get_stats64 NDO
> > before you start dumping free form stuff in ethtool -S.
>
> Completely agree on the point,
On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote:
> You must expose relevant statistics via the normal get_stats64 NDO
> before you start dumping free form stuff in ethtool -S.
Completely agree on the point, Jakub, but to be honest we don't give him
that possibility within the DSA
On Sun, 15 Nov 2020 08:35:33 +0100 Oleksij Rempel wrote:
> +static const struct ar9331_mib_desc ar9331_mib[] = {
> + MIB_DESC(1, 0x00, "RxBroad"),
> + MIB_DESC(1, 0x04, "RxPause"),
> + MIB_DESC(1, 0x08, "RxMulti"),
> + MIB_DESC(1, 0x0c, "RxFcsErr"),
> + MIB_DESC(1, 0x10,
On Sun, Nov 15, 2020 at 08:35:33AM +0100, Oleksij Rempel wrote:
> Add stats support for the ar9331 switch.
>
> Signed-off-by: Oleksij Rempel
Reviewed-by: Andrew Lunn
Andrew
Add stats support for the ar9331 switch.
Signed-off-by: Oleksij Rempel
---
drivers/net/dsa/qca/ar9331.c | 113 +++
1 file changed, 113 insertions(+)
diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
index e24a99031b80..f6947fb0182f 100644
15 matches
Mail list logo
