Re: [PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-05-02 Thread ching
Thanks for Dan's advice. I will revise the patch code. Next upload will be PATCH v1.1 16 patches. On Fri, 2014-05-02 at 11:31 +0300, Dan Carpenter wrote: > On Wed, Apr 30, 2014 at 05:50:12PM +0800, ching wrote: > > From: Ching > > > > Adding code for supporting MSI-X interrupt > > > >

Re: [PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-05-02 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 05:50:12PM +0800, ching wrote: > From: Ching > > Adding code for supporting MSI-X interrupt > > Signed-off-by: Ching > --- These patches seem to be broken up nicely into patches which do one thing per patch and they are much easier to review now. Thanks! > +static int

Re: [PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-05-02 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 05:50:12PM +0800, ching wrote: From: Chingching2...@areca.com.tw Adding code for supporting MSI-X interrupt Signed-off-by: Chingching2...@areca.com.tw --- These patches seem to be broken up nicely into patches which do one thing per patch and they are much easier

Re: [PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-05-02 Thread ching
Thanks for Dan's advice. I will revise the patch code. Next upload will be PATCH v1.1 16 patches. On Fri, 2014-05-02 at 11:31 +0300, Dan Carpenter wrote: On Wed, Apr 30, 2014 at 05:50:12PM +0800, ching wrote: From: Chingching2...@areca.com.tw Adding code for supporting MSI-X interrupt

[PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-04-30 Thread ching
From: Ching Adding code for supporting MSI-X interrupt Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-04-28

[PATCH v1.0 2/16] arcmsr: Support MSI-X interrupt

2014-04-30 Thread ching
From: Chingching2...@areca.com.tw Adding code for supporting MSI-X interrupt Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++