Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-05 Thread Andy Shevchenko
On Mon, Jun 3, 2013 at 3:26 PM, Joe Perches wrote: > On Mon, 2013-06-03 at 11:16 +0300, Andy Shevchenko wrote: >> On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote: >> > On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote: >> > > On 31/05/13 19:27, Andy Shevchenko wrote: >> > > > + sfi_g

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-03 Thread Joe Perches
On Mon, 2013-06-03 at 11:16 +0300, Andy Shevchenko wrote: > On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote: > > On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote: > > > On 31/05/13 19:27, Andy Shevchenko wrote: > > > > + sfi_gpio_table = kmalloc(num * sizeof(*pentry), GFP_KERNEL); >

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-03 Thread Andy Shevchenko
On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote: > On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote: > > On 31/05/13 19:27, Andy Shevchenko wrote: > > Some trivial coding style comment below. Thank you, Joe, for commenting this. > > > + for (i = 0; i < sfi_gpio_num_entry; i++, pentry++)

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-03 Thread Linus Walleij
On Fri, May 31, 2013 at 11:27 AM, Andy Shevchenko wrote: > To support some (legacy) firmwares and platforms let's make life easier for > their customers. > > This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. > > Signed-off-by: Andy Shevchenko > Acked-by: Len Brown > Cc: Grant

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-02 Thread Joe Perches
On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote: > On 31/05/13 19:27, Andy Shevchenko wrote: > Some trivial coding style comment below. [] > > + for (i = 0; i < sfi_gpio_num_entry; i++, pentry++) { > > + if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN)) > > + re

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-02 Thread Ryan Mallon
On 31/05/13 19:27, Andy Shevchenko wrote: > To support some (legacy) firmwares and platforms let's make life easier for > their customers. > > This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. > > Signed-off-by: Andy Shevchenko > Acked-by: Len Brown > Cc: Grant Likely > Cc:

[PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-05-31 Thread Andy Shevchenko
To support some (legacy) firmwares and platforms let's make life easier for their customers. This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. Signed-off-by: Andy Shevchenko Acked-by: Len Brown Cc: Grant Likely Cc: Linus Walleij --- Since v1: - address Linus' comments: sel