Re: [PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-05-09 Thread Purna Chandra Mandal
On 05/07/2016 05:40 AM, Stephen Boyd wrote: > Mostly nitpicks, although I'm worried about the iomem casting and > addition stuff. I suppose if those are fixed up at some later > time then I'm fine with this going through MIPS tree. > > On 03/23, Purna Chandra Mandal wrote: >> +static int

Re: [PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-05-09 Thread Purna Chandra Mandal
On 05/07/2016 05:40 AM, Stephen Boyd wrote: > Mostly nitpicks, although I'm worried about the iomem casting and > addition stuff. I suppose if those are fixed up at some later > time then I'm fine with this going through MIPS tree. > > On 03/23, Purna Chandra Mandal wrote: >> +static int

Re: [PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-05-06 Thread Stephen Boyd
Mostly nitpicks, although I'm worried about the iomem casting and addition stuff. I suppose if those are fixed up at some later time then I'm fine with this going through MIPS tree. On 03/23, Purna Chandra Mandal wrote: > +static int pbclk_set_rate(struct clk_hw *hw, unsigned long rate, > +

Re: [PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-05-06 Thread Stephen Boyd
Mostly nitpicks, although I'm worried about the iomem casting and addition stuff. I suppose if those are fixed up at some later time then I'm fine with this going through MIPS tree. On 03/23, Purna Chandra Mandal wrote: > +static int pbclk_set_rate(struct clk_hw *hw, unsigned long rate, > +

[PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-03-23 Thread Purna Chandra Mandal
This clock driver implements PIC32 specific clock-tree. clock-tree entities can only be configured through device-tree file (OF). Signed-off-by: Purna Chandra Mandal Note: Please pull this complete series through the MIPS tree. --- Changes in v10: - drop

[PATCH v10 2/3] clk: microchip: Add PIC32 clock driver

2016-03-23 Thread Purna Chandra Mandal
This clock driver implements PIC32 specific clock-tree. clock-tree entities can only be configured through device-tree file (OF). Signed-off-by: Purna Chandra Mandal Note: Please pull this complete series through the MIPS tree. --- Changes in v10: - drop early clock init of