Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-06 Thread Nicolas Boichat
On Wed, Jan 6, 2021 at 4:41 PM Roger Lu wrote: > > Hi Nicolas, > > [snip] > > > > > > > + > > > > + /* Svs efuse parsing */ > > > > + ft_pgm = (svsp->efuse[0] >> 4) & GENMASK(3, 0); > > > > + > > > > + for (idx = 0; idx < svsp->bank_num; idx++) { > > > > + svsb =

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-06 Thread Roger Lu
Hi Nicolas, [snip] > > > > > + > > > + /* Svs efuse parsing */ > > > + ft_pgm = (svsp->efuse[0] >> 4) & GENMASK(3, 0); > > > + > > > + for (idx = 0; idx < svsp->bank_num; idx++) { > > > + svsb = >banks[idx]; > > > + > > > + if (ft_pgm <= 1) > > > +

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-04 Thread Roger Lu
Hi Nicolas, On Mon, 2021-01-04 at 17:27 +0800, Nicolas Boichat wrote: > On Mon, Jan 4, 2021 at 4:51 PM Roger Lu wrote: > > > > > > Hi Nicolas, > > > > Thanks for all the advices. > > > > On Thu, 2020-12-31 at 10:10 +0800, Nicolas Boichat wrote: > > > On Sun, Dec 27, 2020 at 6:55 PM Roger Lu

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-04 Thread Nicolas Boichat
On Mon, Jan 4, 2021 at 4:51 PM Roger Lu wrote: > > > Hi Nicolas, > > Thanks for all the advices. > > On Thu, 2020-12-31 at 10:10 +0800, Nicolas Boichat wrote: > > On Sun, Dec 27, 2020 at 6:55 PM Roger Lu wrote: [snip] > > > +static int svs_adjust_pm_opp_volts(struct svs_bank *svsb, bool > > >

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2021-01-04 Thread Roger Lu
Hi Nicolas, Thanks for all the advices. On Thu, 2020-12-31 at 10:10 +0800, Nicolas Boichat wrote: > On Sun, Dec 27, 2020 at 6:55 PM Roger Lu wrote: > > > > The Smart Voltage Scaling(SVS) engine is a piece of hardware > > which calculats suitable SVS bank voltages to OPP voltage table. > >

Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

2020-12-30 Thread Nicolas Boichat
On Sun, Dec 27, 2020 at 6:55 PM Roger Lu wrote: > > The Smart Voltage Scaling(SVS) engine is a piece of hardware > which calculats suitable SVS bank voltages to OPP voltage table. calculates > Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck > when receiving