Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

On Thu, 2021-01-28 at 13:09 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 12:39 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > > There may be data structure other than mtk_ddp_comp_dev that would call > > > mtk_dither_set(), so use

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

On Thu, Jan 28, 2021 at 12:39 PM CK Hu wrote: > > Hi, Hsin-Yi: > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > There may be data structure other than mtk_ddp_comp_dev that would call > > mtk_dither_set(), so use regs as parameter instead of device. > > You does not change the

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > There may be data structure other than mtk_ddp_comp_dev that would call > mtk_dither_set(), so use regs as parameter instead of device. You does not change the interface of mtk_dither_set(). You move the common part in

[PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

There may be data structure other than mtk_ddp_comp_dev that would call mtk_dither_set(), so use regs as parameter instead of device. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 25 + 2