Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-13 Thread Alexandre Belloni
On 13/07/2018 12:56:22+0300, Radu Pirea wrote: > > > On 07/10/2018 09:15 PM, Mark Brown wrote: > > On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: > > > > This is mostly good, just a couple of small things: > > > > > +config SPI_AT91_USART > > > + tristate "Atmel USART Controller

Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-13 Thread Alexandre Belloni
On 13/07/2018 12:56:22+0300, Radu Pirea wrote: > > > On 07/10/2018 09:15 PM, Mark Brown wrote: > > On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: > > > > This is mostly good, just a couple of small things: > > > > > +config SPI_AT91_USART > > > + tristate "Atmel USART Controller

Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-13 Thread Radu Pirea
On 07/10/2018 09:15 PM, Mark Brown wrote: On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: This is mostly good, just a couple of small things: +config SPI_AT91_USART + tristate "Atmel USART Controller SPI driver" + depends on HAS_DMA + depends on (ARCH_AT91 ||

Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-13 Thread Radu Pirea
On 07/10/2018 09:15 PM, Mark Brown wrote: On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: This is mostly good, just a couple of small things: +config SPI_AT91_USART + tristate "Atmel USART Controller SPI driver" + depends on HAS_DMA + depends on (ARCH_AT91 ||

Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-10 Thread Mark Brown
On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: This is mostly good, just a couple of small things: > +config SPI_AT91_USART > + tristate "Atmel USART Controller SPI driver" > + depends on HAS_DMA > + depends on (ARCH_AT91 || COMPILE_TEST) > + select MFD_AT91_USART

Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-07-10 Thread Mark Brown
On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: This is mostly good, just a couple of small things: > +config SPI_AT91_USART > + tristate "Atmel USART Controller SPI driver" > + depends on HAS_DMA > + depends on (ARCH_AT91 || COMPILE_TEST) > + select MFD_AT91_USART

[PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-06-25 Thread Radu Pirea
This is the driver for at91-usart in spi mode. The USART IP can be configured to work in many modes and one of them is SPI. The driver was tested on sama5d3-xplained and sama5d4-xplained boards with enc28j60 ethernet controller as slave. Signed-off-by: Radu Pirea Reviewed-by: Andy Shevchenko

[PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

2018-06-25 Thread Radu Pirea
This is the driver for at91-usart in spi mode. The USART IP can be configured to work in many modes and one of them is SPI. The driver was tested on sama5d3-xplained and sama5d4-xplained boards with enc28j60 ethernet controller as slave. Signed-off-by: Radu Pirea Reviewed-by: Andy Shevchenko