On Mai 07 2019, Yash Shah wrote:
> Leds on HiFive Unleashed are wired to supply instead of ground.
> And as per ./Documentation/devicetree/bindings/leds/leds-pwm.txt, you
> need to provide additional property "active-low" in such case.
>
> - active-low : (optional) For PWMs where the LED is
Hi Andreas,
On Tue, May 7, 2019 at 3:09 PM Andreas Schwab wrote:
>
> On Mai 02 2019, Yash Shah wrote:
>
> > The PWM default output state is high (When duty cycle is 0), So I
> > guess leds will remain on by default.
>
> So that's the bug that needs to be fixed.
Sorry I didn't probably get you
On Mai 02 2019, Yash Shah wrote:
> The PWM default output state is high (When duty cycle is 0), So I
> guess leds will remain on by default.
So that's the bug that needs to be fixed.
Andreas.
--
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748
Hi Andreas,
On Wed, Mar 27, 2019 at 2:34 PM Andreas Schwab wrote:
>
> I have now found out that the ledtrig modules don't load automatically.
> I would have expected that the linux,default-trigger entries would cause
> the load of the corresponding ledtrig modules.
>
> But there is another
On Mon, Apr 15, 2019 at 11:36:51AM +0530, Yash Shah wrote:
> Hi,
>
> Any comments on this patch series?
> Any more changes are needed or it looks good to be merged upstream?
In my eyes it would be great if Andreas Schwab was able to resolve the
problems he pointed out in this thread.
Best
Hi,
Any comments on this patch series?
Any more changes are needed or it looks good to be merged upstream?
- Yash
I have now found out that the ledtrig modules don't load automatically.
I would have expected that the linux,default-trigger entries would cause
the load of the corresponding ledtrig modules.
But there is another problem, that the leds are on by default.
Shouldn't they be off by default?
On Mär 26 2019, Yash Shah wrote:
> 'On Mon, Mar 25, 2019 at 9:24 PM Andreas Schwab wrote:
>>
>>
>> I still don't see any improvement. FYI, this is the patch I use for the
>> device tree:
>>
>
> I am sharing you my test environment which has been working for me so
> that you can duplicate at
'On Mon, Mar 25, 2019 at 9:24 PM Andreas Schwab wrote:
>
>
> I still don't see any improvement. FYI, this is the patch I use for the
> device tree:
>
I am sharing you my test environment which has been working for me so
that you can duplicate at your end
I have tested the patch on Linux
On Mär 25 2019, Yash Shah wrote:
> v11
> - Change naming convention for pwm_device and pwm_sifive_ddata pointers
> - Assign of_pwm_xlate_with_flag() to of_xlate func ptr since this driver
> use three pwm-cells (Issue reported by Andreas Schwab
> - Other minor fixes
I still don't see any
This patch series adds a PWM driver and DT documentation
for HiFive Unleashed board. The patches are mostly based on
Wesley's patch.
This patchset is based on Linux 5.0-rc1 and tested on HiFive Unleashed board
with additional board related patches needed for testing can be found at
11 matches
Mail list logo
