Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-16 Thread Andrey Ryabinin
On 02/16/2015 05:44 AM, Rusty Russell wrote: > Andrey Ryabinin writes: >> MODULE_DEVICE_TABLE() macro used to create aliases to device tables. >> Normally alias should have the same type as aliased symbol. >> >> Device tables are arrays, so they have 'struct type##_device_id[x]' >> types. Alias

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-16 Thread Andrey Ryabinin
On 02/16/2015 05:44 AM, Rusty Russell wrote: Andrey Ryabinin a.ryabi...@samsung.com writes: MODULE_DEVICE_TABLE() macro used to create aliases to device tables. Normally alias should have the same type as aliased symbol. Device tables are arrays, so they have 'struct type##_device_id[x]'

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-15 Thread Rusty Russell
Andrey Ryabinin writes: > MODULE_DEVICE_TABLE() macro used to create aliases to device tables. > Normally alias should have the same type as aliased symbol. > > Device tables are arrays, so they have 'struct type##_device_id[x]' > types. Alias created by MODULE_DEVICE_TABLE() will have non-array

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-15 Thread Rusty Russell
Andrey Ryabinin a.ryabi...@samsung.com writes: MODULE_DEVICE_TABLE() macro used to create aliases to device tables. Normally alias should have the same type as aliased symbol. Device tables are arrays, so they have 'struct type##_device_id[x]' types. Alias created by MODULE_DEVICE_TABLE()

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrew Morton
On Tue, 03 Feb 2015 19:01:08 -0500 Sasha Levin wrote: > > diff -puN > > drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites > > drivers/scsi/be2iscsi/be_main.c > > --- a/drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites > > +++

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Sasha Levin
On 02/03/2015 06:51 PM, Andrew Morton wrote: > From: Andrew Morton > Subject: MODULE_DEVICE_TABLE: fix some callsites > > The patch "module: fix types of device tables aliases" newly requires that > invokations of invocations > > MODULE_DEVICE_TABLE(type, name); > > come *after* the

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrew Morton
On Tue, 03 Feb 2015 20:43:11 +0300 Andrey Ryabinin wrote: > MODULE_DEVICE_TABLE() macro used to create aliases to device tables. > Normally alias should have the same type as aliased symbol. > > Device tables are arrays, so they have 'struct type##_device_id[x]' > types. Alias created by

[PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrey Ryabinin
MODULE_DEVICE_TABLE() macro used to create aliases to device tables. Normally alias should have the same type as aliased symbol. Device tables are arrays, so they have 'struct type##_device_id[x]' types. Alias created by MODULE_DEVICE_TABLE() will have non-array type - 'struct

[PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrey Ryabinin
MODULE_DEVICE_TABLE() macro used to create aliases to device tables. Normally alias should have the same type as aliased symbol. Device tables are arrays, so they have 'struct type##_device_id[x]' types. Alias created by MODULE_DEVICE_TABLE() will have non-array type - 'struct

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrew Morton
On Tue, 03 Feb 2015 20:43:11 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: MODULE_DEVICE_TABLE() macro used to create aliases to device tables. Normally alias should have the same type as aliased symbol. Device tables are arrays, so they have 'struct type##_device_id[x]' types. Alias

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Sasha Levin
On 02/03/2015 06:51 PM, Andrew Morton wrote: From: Andrew Morton a...@linux-foundation.org Subject: MODULE_DEVICE_TABLE: fix some callsites The patch module: fix types of device tables aliases newly requires that invokations of invocations MODULE_DEVICE_TABLE(type, name); come

Re: [PATCH v11 18/19] module: fix types of device tables aliases

2015-02-03 Thread Andrew Morton
On Tue, 03 Feb 2015 19:01:08 -0500 Sasha Levin sasha.le...@oracle.com wrote: diff -puN drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites drivers/scsi/be2iscsi/be_main.c --- a/drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites +++