Re: [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-09-29 Thread Brian Norris
On Fri, Sep 04, 2015 at 07:10:10AM +0300, Alexey Klimov wrote: > On Thu, Sep 3, 2015 at 4:06 AM, Stefan Agner wrote: > > --- /dev/null > > +++ b/drivers/mtd/nand/vf610_nfc.c > > +static int vf610_nfc_probe(struct platform_device *pdev) > > +{ > > + struct vf610_nfc *nfc; > > + struct

Re: [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-09-03 Thread Alexey Klimov
Hi Stefan, just few very small comments. On Thu, Sep 3, 2015 at 4:06 AM, Stefan Agner wrote: [..] > --- /dev/null > +++ b/drivers/mtd/nand/vf610_nfc.c [..] > +static inline u32 vf610_nfc_read(struct vf610_nfc *nfc, uint reg) > +{ > + return readl(nfc->regs + reg); > +} > + > +static in

[PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-09-02 Thread Stefan Agner
This driver supports Freescale NFC (NAND flash controller) found on Vybrid (VF610), MPC5125, MCF54418 and Kinetis K70. The driver has been tested using 8-bit and 16-bit NAND interface on the ARM based Vybrid SoC VF500 and VF610 platform. parameter page reading. Limitations: - Untested on MPC5125 a