Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-18 Thread Viresh Kumar
On 18-12-18, 11:13, Stephen Boyd wrote: > I don't see any failure returned from cpufreq_dt's cpufreq_init() > function. Maybe put a static int counter = 0 and then fail > cpufreq_init() the second time that it's called for the same policy > pointer? I have a system with two policies, so I made it

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-18 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-17 21:45:45) > Hi Stephen, > > On 13-12-18, 02:12, Stephen Boyd wrote: > > Quoting Viresh Kumar (2018-12-13 02:05:06) > > > On 13-12-18, 01:58, Stephen Boyd wrote: > > > > BTW, Viresh, I see a lockdep splat when cpufreq_init returns an error > > > > upon bringing the

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-17 Thread Viresh Kumar
Hi Stephen, On 13-12-18, 02:12, Stephen Boyd wrote: > Quoting Viresh Kumar (2018-12-13 02:05:06) > > On 13-12-18, 01:58, Stephen Boyd wrote: > > > BTW, Viresh, I see a lockdep splat when cpufreq_init returns an error > > > upon bringing the policy online the second time. I guess cpufreq_stats > >

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Taniya Das
Hello Stephen, Viresh, On 12/13/2018 3:28 PM, Stephen Boyd wrote: Quoting Taniya Das (2018-12-12 23:49:54) The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine.

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Matthias Kaehlcke
On Thu, Dec 13, 2018 at 01:19:54PM +0530, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan >

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Viresh Kumar
On 13-12-18, 02:32, Stephen Boyd wrote: > I have one policy for four CPUs. So take down all four of those CPUs by > writing a 0 to the online file for each CPU, and then bring them back > online. That should make cpufreq_driver->init() be called twice, once > during boot when the CPUs are bound to

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-13 02:14:17) > On 13-12-18, 02:12, Stephen Boyd wrote: > > It's on a v4.19 kernel with this cpufreq hw driver backported to it. I > > think all it takes is to return an error the second time the policy is > > initialized when cpufreq_online() calls into the cpufreq

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Viresh Kumar
On 13-12-18, 02:12, Stephen Boyd wrote: > It's on a v4.19 kernel with this cpufreq hw driver backported to it. I > think all it takes is to return an error the second time the policy is > initialized when cpufreq_online() calls into the cpufreq driver. What do you mean by "the second time the

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-13 02:05:06) > On 13-12-18, 01:58, Stephen Boyd wrote: > > BTW, Viresh, I see a lockdep splat when cpufreq_init returns an error > > upon bringing the policy online the second time. I guess cpufreq_stats > > aren't able to be freed from there because they take locks

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Viresh Kumar
On 13-12-18, 01:58, Stephen Boyd wrote: > BTW, Viresh, I see a lockdep splat when cpufreq_init returns an error > upon bringing the policy online the second time. I guess cpufreq_stats > aren't able to be freed from there because they take locks in different > order vs. the normal path? Please

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Stephen Boyd
Quoting Taniya Das (2018-12-12 23:49:54) > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Signed-off-by: Stephen

Re: [PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-13 Thread Viresh Kumar
On 13-12-18, 13:19, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Signed-off-by: Stephen Boyd

[PATCH v12 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-12 Thread Taniya Das
The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine. Signed-off-by: Saravana Kannan Signed-off-by: Stephen Boyd Signed-off-by: Taniya Das ---