Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Geert Uytterhoeven
Hi Sergei, On Wed, May 22, 2019 at 7:23 PM Sergei Shtylyov wrote: > On 05/22/2019 08:05 PM, Geert Uytterhoeven wrote: > >> On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: > >>> +- clocks: should contain 1 entries for the module's clock > >> > >>1 entry (clock node phandle and

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Sergei Shtylyov
On 05/22/2019 08:05 PM, Geert Uytterhoeven wrote: >> On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: >>> +- clocks: should contain 1 entries for the module's clock >> >>1 entry (clock node phandle and specifier). > > Doesn't "specifier" mean "phandle + optional arguments"? No.

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Geert Uytterhoeven
Hi Sergei, On Wed, May 22, 2019 at 6:32 PM Sergei Shtylyov wrote: > On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: > > +- clocks: should contain 1 entries for the module's clock > >1 entry (clock node phandle and specifier). Doesn't "specifier" mean "phandle + optional arguments"?

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Sergei Shtylyov
On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: > --> > > Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings > - > > RPC-IF supports both SPI

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-20 Thread masonccyang
Hi Geert, > > On Mon, May 20, 2019 at 9:24 AM wrote: > > > >>> - clocks: should contain 1 entries for the module's clock > > > >>> - clock-names: should contain "rpc" > > > >> > > > >>I suspect we'd need the RPC/RPCD2 clocks mentioned as well (not > > sure > > > > yet)... > > > > > >

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-20 Thread Geert Uytterhoeven
Hi Mason, On Mon, May 20, 2019 at 9:24 AM wrote: > > >>> - clocks: should contain 1 entries for the module's clock > > >>> - clock-names: should contain "rpc" > > >> > > >>I suspect we'd need the RPC/RPCD2 clocks mentioned as well (not > sure > > > yet)... > > > > > > Need it ? > > > >

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-20 Thread masonccyang
Hi Sergei, > >>> --> > >>> > >>> Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings > >>> - > >>> > >>> RPC-IF supports both SPI NOR and HyperFlash (CFI-compliant flash)

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-14 Thread Sergei Shtylyov
On 05/14/2019 12:46 PM, masonccy...@mxic.com.tw wrote: There's precedence for such constructs being an MFD: please see drivers/mfd/at91-usart.c, which registers a single MFD cell for > either serial or SPI. >> >>Thanks fir your example, Geert! :-) s/fir/for/, not the

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-14 Thread Geert Uytterhoeven
Hi Mason, On Tue, May 14, 2019 at 11:46 AM wrote: > > >> There's precedence for such constructs being an MFD: please see > > >> drivers/mfd/at91-usart.c, which registers a single MFD cell for > > > second for the direct mapping read mode and > > > third for the write buffer

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-14 Thread masonccyang
Hi Sergei, > > > >Could you please indent with 1 or 2 tabs where you used 8 or 16 spaces? Sorry, I just copy this new DTS from git to my Notes email system, therefore, the "tabs space" is not alignment with original file. > > Patch new DTS to >

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-14 Thread masonccyang
Hello, > >> There's precedence for such constructs being an MFD: please see > >> drivers/mfd/at91-usart.c, which registers a single MFD cell for either > >> serial or SPI. > >Thanks fir your example, Geert! :-) > > > okay, many thanks for your information. > > > > How about to patch

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread masonccyang
Hi Geert, > Subject > > Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings > > Hi Mason, > > Note that if you send multipart/text+html emails, they will be dropped silently > by most Linux mailing lists. > Hence I'm quoting you

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread Sergei Shtylyov
Hello! On 05/13/2019 12:37 PM, masonccy...@mxic.com.tw wrote: >> > > [...] >> > > >> > >> > On 4/24/19 11:23 PM, Rob Herring wrote: >> > > >> > >> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: >> > > >> > >> > >> Document the bindings used by the Renesas R-Car >> Gen3 RPC-IF

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread Geert Uytterhoeven
Hi Mason, Note that if you send multipart/text+html emails, they will be dropped silently by most Linux mailing lists. Hence I'm quoting your last email fully, to give other people a chance reading it (and commenting). On Mon, May 13, 2019 at 11:37 AM wrote: > > > > [...] > > > > >> > >> > On

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread Geert Uytterhoeven
Hi Mason, On Fri, May 10, 2019 at 3:09 AM wrote: > > "Sergei Shtylyov" > > 2019/05/10 上午 03:24 > > mark.rutl...@arm.com, "Rob Herring" , > > zhengxu...@mxic.com.tw > > On 05/09/2019 05:06 AM, masonccy...@mxic.com.tw wrote: > > > > [...] > > >> > >> > On 4/24/19 11:23 PM, Rob Herring wrote: > >