Re: [PATCH v13] NVMe: Convert to blk-mq

2014-09-30 Thread Matias Bjørling
On Tue, Sep 30, 2014 at 7:42 PM, Keith Busch wrote: > On Tue, 30 Sep 2014, Matias Bjørling wrote: >> >> @@ -1967,27 +1801,30 @@ static struct nvme_ns *nvme_alloc_ns(struct >> nvme_dev *dev, unsigned nsid, >> { > > ... >> >> - ns->queue->queue_flags = QUEUE_FLAG_DEFAULT; >> + queue_flag

Re: [PATCH v13] NVMe: Convert to blk-mq

2014-09-30 Thread Keith Busch
On Tue, 30 Sep 2014, Matias Bjørling wrote: @@ -1967,27 +1801,30 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, unsigned nsid, { ... - ns->queue->queue_flags = QUEUE_FLAG_DEFAULT; + queue_flag_set_unlocked(QUEUE_FLAG_DEFAULT, ns->queue); Instead of the above, you w

[PATCH v13] NVMe: Convert to blk-mq

2014-09-30 Thread Matias Bjørling
This converts the NVMe driver to a blk-mq request-based driver. The NVMe driver is currently bio-based and implements queue logic within itself. By using blk-mq, a lot of these responsibilities can be moved and simplified. The patch is divided into the following blocks: * Per-command data and c