Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-28 Thread Andy Shevchenko
On Thu, Mar 28, 2019 at 01:40:04PM +0900, William Breathitt Gray wrote: > On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > > Replace verbose implementation in set_multiple callback with > > >

Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-27 Thread William Breathitt Gray
On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. > > > +

Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-27 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity. > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > + bank

[PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-26 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Suggested-by: Andy Shevchenko Cc: Geert Uytterhoeven Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-74x164.c | 19 +-- 1