RE: [EXT] Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-11 Thread Stefan Chulski
> On Thu, Feb 11, 2021 at 12:48:51PM +0200, stef...@marvell.com wrote: > > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct > > mvpp2_port *port) > > > > static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port) { > > - return !(port->priv->hw_version == MVPP22 &&

Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:51PM +0200, stef...@marvell.com wrote: > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct mvpp2_port > *port) > > static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port) > { > - return !(port->priv->hw_version == MVPP22 && port->gop_id

[PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-11 Thread stefanc
From: Stefan Chulski Currently we have PP2v1 and PP2v2 hw-versions, with some different handlers depending upon condition hw_version = MVPP21/MVPP22. In a future there will be also PP2v3. Let's use now the generic "if equal/notEqual MVPP21" for all cases instead of "if MVPP22". This patch does