Re: [PATCH v14 10/13] KVM: x86: Enable CET virtualization for VMX and advertise CET to userspace

2021-01-31 Thread Yang Weijiang
On Fri, Jan 29, 2021 at 03:38:52PM +0100, Paolo Bonzini wrote: > On 29/01/21 13:17, Yang Weijiang wrote: > > > > It's specific to VM case, during VM reboot, memory mode reset but > > > > VM_ENTRY_LOAD_CET_STATE > > > > is still set, and VMCS contains stale GUEST_SSP, this hits vm-entry > > > >

Re: [PATCH v14 10/13] KVM: x86: Enable CET virtualization for VMX and advertise CET to userspace

2021-01-30 Thread Yang Weijiang
On Fri, Jan 29, 2021 at 03:38:52PM +0100, Paolo Bonzini wrote: > On 29/01/21 13:17, Yang Weijiang wrote: > > > > It's specific to VM case, during VM reboot, memory mode reset but > > > > VM_ENTRY_LOAD_CET_STATE > > > > is still set, and VMCS contains stale GUEST_SSP, this hits vm-entry > > > >

Re: [PATCH v14 10/13] KVM: x86: Enable CET virtualization for VMX and advertise CET to userspace

2021-01-28 Thread Paolo Bonzini
On 06/11/20 02:16, Yang Weijiang wrote: + + if (((cr4 ^ old_cr4) & X86_CR4_CET) && kvm_cet_supported()) { + vmcs_writel(GUEST_SSP, 0); + vmcs_writel(GUEST_S_CET, 0); + vmcs_writel(GUEST_INTR_SSP_TABLE, 0); + } + Is this behavior documented

Re: [PATCH v14 10/13] KVM: x86: Enable CET virtualization for VMX and advertise CET to userspace

2020-11-08 Thread kernel test robot
Hi Yang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/master] [also build test WARNING on linus/master v5.10-rc3 next-20201106] [cannot apply to vhost/linux-next kvm/linux-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us

[PATCH v14 10/13] KVM: x86: Enable CET virtualization for VMX and advertise CET to userspace

2020-11-05 Thread Yang Weijiang
Set the feature bits so that CET capabilities can be seen in guest via CPUID enumeration. Add CR4.CET bit support in order to allow guest set CET master control bit(CR4.CET). Disable KVM CET feature if unrestricted_guest is unsupported/disabled as KVM does not support emulating CET. Reset guest