Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Akinobu Mita
2013/7/17 Paul Bolle : > On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote: >> This one looks good to me. > > Thanks. > >> It would be much better if this commit >> log had a reference to the commit that introduced this warning as >> you described after '---' in v1 patch. > > Do you mean that

Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Paul Bolle
On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote: > This one looks good to me. Thanks. > It would be much better if this commit > log had a reference to the commit that introduced this warning as > you described after '---' in v1 patch. Do you mean that I should submit a v3, with a commit

Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Akinobu Mita
2013/7/16 Paul Bolle : > Building scsi_debug.o triggers a GCC warning: > drivers/scsi/scsi_debug.c: In function ‘dif_verify’: > drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > > This is a false positive. But if we

Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Akinobu Mita
2013/7/16 Paul Bolle pebo...@tiscali.nl: Building scsi_debug.o triggers a GCC warning: drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive.

Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Paul Bolle
On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote: This one looks good to me. Thanks. It would be much better if this commit log had a reference to the commit that introduced this warning as you described after '---' in v1 patch. Do you mean that I should submit a v3, with a commit

Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-16 Thread Akinobu Mita
2013/7/17 Paul Bolle pebo...@tiscali.nl: On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote: This one looks good to me. Thanks. It would be much better if this commit log had a reference to the commit that introduced this warning as you described after '---' in v1 patch. Do you mean

[PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-15 Thread Paul Bolle
Building scsi_debug.o triggers a GCC warning: drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive. But if we transform the switch statement in

[PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-15 Thread Paul Bolle
Building scsi_debug.o triggers a GCC warning: drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive. But if we transform the switch statement in