Re: [PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Sergei Shtylyov
Hello. On 03/29/2013 08:12 PM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 Please, also specify that commit's summary line in parens (or however you like). changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed

Re: [PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Krzysztof Mazur
On Fri, Mar 29, 2013 at 10:12:46AM -0700, Gwendal Grignou wrote: > commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key > used for returning task registers, but HDIO_DRIVE_CMD ioctl was > not changed accordingly. > > Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD

[PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signed-off-by: Gwendal Grignou ---

[PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Change-Id: I84dccd3febb0467a83a39e55ecfdaaa9686332cd

[PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Change-Id: I84dccd3febb0467a83a39e55ecfdaaa9686332cd

[PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signed-off-by: Gwendal Grignou gwen...@google.com ---

Re: [PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Krzysztof Mazur
On Fri, Mar 29, 2013 at 10:12:46AM -0700, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0

Re: [PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Sergei Shtylyov
Hello. On 03/29/2013 08:12 PM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 Please, also specify that commit's summary line in parens (or however you like). changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed