Re: [PATCH v2] [media] v4l: add I / P frame min max QP definitions

2019-01-30 Thread Fish Lin
Hi Hans, For I frame min QP, if global min QP is set, the QP choose algorithm should meet both of them, hence QP will >= max(V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP, V4L2_CID_MPEG_VIDEO_H264_MIN_QP). And this is also the same to the P frame and max QP. I can add some description to describe this

Re: [PATCH v2] [media] v4l: add I / P frame min max QP definitions

2019-01-29 Thread Hans Verkuil
On 1/30/19 8:45 AM, Fish Lin wrote: > Add following V4L2 QP parameters for H.264: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP > > These controls will limit QP

[PATCH v2] [media] v4l: add I / P frame min max QP definitions

2019-01-29 Thread Fish Lin
Add following V4L2 QP parameters for H.264: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP These controls will limit QP range for intra and inter frame, provide more manual