Re: [PATCH v2] ACPI / hotplug / PCI: fix memory leak in enable_slot()

2021-04-08 Thread Bjorn Helgaas
On Thu, Mar 25, 2021 at 03:26:00PM +0800, Zhiqiang Liu wrote: > From: Feilong Lin > > In enable_slot() in drivers/pci/hotplug/acpiphp_glue.c, if pci_get_slot() > will return NULL, we will do not set SLOT_ENABLED flag of slot. if one > device is found by calling pci_get_slot(), its reference

Re: [PATCH v2] ACPI / hotplug / PCI: fix memory leak in enable_slot()

2021-04-08 Thread Bjorn Helgaas
On Thu, Apr 08, 2021 at 05:18:46PM +0200, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:27 AM Zhiqiang Liu wrote: > > > > From: Feilong Lin > > > > In enable_slot() in drivers/pci/hotplug/acpiphp_glue.c, if pci_get_slot() > > will return NULL, we will do not set SLOT_ENABLED flag of slot.

Re: [PATCH v2] ACPI / hotplug / PCI: fix memory leak in enable_slot()

2021-04-08 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:27 AM Zhiqiang Liu wrote: > > From: Feilong Lin > > In enable_slot() in drivers/pci/hotplug/acpiphp_glue.c, if pci_get_slot() > will return NULL, we will do not set SLOT_ENABLED flag of slot. if one > device is found by calling pci_get_slot(), its reference count will

[PATCH v2] ACPI / hotplug / PCI: fix memory leak in enable_slot()

2021-03-25 Thread Zhiqiang Liu
From: Feilong Lin In enable_slot() in drivers/pci/hotplug/acpiphp_glue.c, if pci_get_slot() will return NULL, we will do not set SLOT_ENABLED flag of slot. if one device is found by calling pci_get_slot(), its reference count will be increased. In this case, we did not call pci_dev_put() to