RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-15 Thread li.xi...@freescale.com
> > 2, If the regulator dt node is exist but the optional VDDD is absent (i.e. > > The external VDDD is not used), a -EPROBE_DEFER will be returned, if > > just return the -EPROBE_DEFER to the probe(and then the probe deferral > > mechanism will do the probe again later, is that right ?), and

RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-15 Thread li.xi...@freescale.com
2, If the regulator dt node is exist but the optional VDDD is absent (i.e. The external VDDD is not used), a -EPROBE_DEFER will be returned, if just return the -EPROBE_DEFER to the probe(and then the probe deferral mechanism will do the probe again later, is that right ?), and then the

Re: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 09:49:47AM +, Li Xiubo wrote: > 2, If the regulator dt node is exist but the optional VDDD is absent (i.e. > The external VDDD is not used), a -EPROBE_DEFER will be returned, if just > return the -EPROBE_DEFER to the probe(and then the probe deferral > mechanism will

RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-03 Thread Li Xiubo
> > +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec) { > > + struct regulator *consumer; > > + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec); > > + > > + consumer = regulator_get_optional(codec->dev, > > +

RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-03 Thread Li Xiubo
+static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec) { + struct regulator *consumer; + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec); + + consumer = regulator_get_optional(codec-dev, + sgtl5000-supplies[VDDD].supply); + if

Re: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 09:49:47AM +, Li Xiubo wrote: 2, If the regulator dt node is exist but the optional VDDD is absent (i.e. The external VDDD is not used), a -EPROBE_DEFER will be returned, if just return the -EPROBE_DEFER to the probe(and then the probe deferral mechanism will do

Re: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-11-29 Thread Mark Brown
On Thu, Nov 28, 2013 at 02:46:59PM +0800, Xiubo Li wrote: > +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec) > +{ > + struct regulator *consumer; > + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec); > + > + consumer =

Re: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-11-29 Thread Mark Brown
On Thu, Nov 28, 2013 at 02:46:59PM +0800, Xiubo Li wrote: +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec) +{ + struct regulator *consumer; + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec); + + consumer = regulator_get_optional(codec-dev,

[PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-11-27 Thread Xiubo Li
The SGTL5000 requires 2 external power supplies: VDDA and VDDIO. An optional third external power supply VDDD may be provided externally to achieve lower power.If an external supply is not used for VDDD, the SGTL5000 driver will register it's own regulator device, and then provides the VDDD supply

[PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-11-27 Thread Xiubo Li
The SGTL5000 requires 2 external power supplies: VDDA and VDDIO. An optional third external power supply VDDD may be provided externally to achieve lower power.If an external supply is not used for VDDD, the SGTL5000 driver will register it's own regulator device, and then provides the VDDD supply