Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-17 Thread Mark Brown
On Fri, Mar 17, 2017 at 02:41:04AM +, Kai-Heng Feng wrote: > On Thu, Mar 16, 2017 at 10:09 PM Mark Brown wrote: > > > + rt286->is_dell_dino = dmi_check_system(dmi_dell_dino) ? true : > > false; > > Just directly assign the boolean value, the ternery operator is just

Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-17 Thread Mark Brown
On Fri, Mar 17, 2017 at 02:41:04AM +, Kai-Heng Feng wrote: > On Thu, Mar 16, 2017 at 10:09 PM Mark Brown wrote: > > > + rt286->is_dell_dino = dmi_check_system(dmi_dell_dino) ? true : > > false; > > Just directly assign the boolean value, the ternery operator is just > > making thins

Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-16 Thread Mark Brown
On Thu, Mar 16, 2017 at 04:39:51PM +0800, Kai-Heng Feng wrote: > + switch (event) { > + case SND_SOC_DAPM_PRE_PMD: > + case SND_SOC_DAPM_POST_PMD: > + case SND_SOC_DAPM_POST_PMU: > + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE); > + break; > +

Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-16 Thread Mark Brown
On Thu, Mar 16, 2017 at 04:39:51PM +0800, Kai-Heng Feng wrote: > + switch (event) { > + case SND_SOC_DAPM_PRE_PMD: > + case SND_SOC_DAPM_POST_PMD: > + case SND_SOC_DAPM_POST_PMU: > + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE); > + break; > +

[PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-16 Thread Kai-Heng Feng
HDA mode fixed the issue by these two commits: '9476d369d7b3 ALSA: hda - Mute headphone pin on suspend on XPS13 9333' '3e1b0c4a9d56 ALSA: hda - Fix click noise at start on Dell XPS13' Apply the same workarounds to rt286 can solve the issue. When jack is plugged, it rapidly generates I2C

[PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-16 Thread Kai-Heng Feng
HDA mode fixed the issue by these two commits: '9476d369d7b3 ALSA: hda - Mute headphone pin on suspend on XPS13 9333' '3e1b0c4a9d56 ALSA: hda - Fix click noise at start on Dell XPS13' Apply the same workarounds to rt286 can solve the issue. When jack is plugged, it rapidly generates I2C