Re: [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-07 Thread Mark Brown
On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote: > + { TFA9879_MISC_STATUS, 0x }, /* 0x15, read-only */ The fix here is the wrong way round - if the device is reporting status here there should be no default and there should be a volatile operation (though it's not

Re: [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-07 Thread Mark Brown
On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote: + { TFA9879_MISC_STATUS, 0x }, /* 0x15, read-only */ The fix here is the wrong way round - if the device is reporting status here there should be no default and there should be a volatile operation (though it's not

[PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 323 sound/soc/codecs/tfa9879.h | 202

[PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 323