Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-11 Thread Darren Hart
On Mon, Sep 11, 2017 at 12:46:14PM +0300, Mika Westerberg wrote: > On Mon, Sep 11, 2017 at 02:39:55AM -0700, Darren Hart wrote: > > Which device are you referring to? This attribute is bound to the device > > identified by the WMI GUID, and should be independent from the controller > > or any > >

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-11 Thread Mika Westerberg
On Mon, Sep 11, 2017 at 02:39:55AM -0700, Darren Hart wrote: > Which device are you referring to? This attribute is bound to the device > identified by the WMI GUID, and should be independent from the controller or > any > thunderbolt connected physical device. I refer to "wdev->dev" whatever tha

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-11 Thread Darren Hart
a Westerberg [mailto:mika.westerb...@linux.intel.com] > > > > Sent: Friday, September 8, 2017 3:07 AM > > > > To: Limonciello, Mario > > > > Cc: dvh...@infradead.org; LKML ; > > > > platform-driver- > > > > x...@vger.kernel.org; Richard Hughe

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-09 Thread Mika Westerberg
ember 8, 2017 3:07 AM > > > To: Limonciello, Mario > > > Cc: dvh...@infradead.org; LKML ; > > > platform-driver- > > > x...@vger.kernel.org; Richard Hughes ; Yehezkel > > > Bernat > > > > > > Subject: Re: [PATCH v2] Add driver to force

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-08 Thread Darren Hart
dead.org; LKML ; > > platform-driver- > > x...@vger.kernel.org; Richard Hughes ; Yehezkel Bernat > > > > Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power > > status > > > > On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Li

RE: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-08 Thread Mario.Limonciello
; > Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power > status > > On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote: > > I have a small comment which you might want to consider. > > > +static int intel_wmi_thunderbolt_p

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-08 Thread Mika Westerberg
On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote: I have a small comment which you might want to consider. > +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev) > +{ > + return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group); > +} > + > +static int inte

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-07 Thread Darren Hart
io > > Cc: mika.westerb...@linux.intel.com; linux-kernel@vger.kernel.org; platform- > > driver-...@vger.kernel.org; hughsi...@gmail.com > > Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power > > status > > > > > > > +Contact:       "M

RE: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-07 Thread Mario.Limonciello
kernel.org; hughsi...@gmail.com > Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power > status > > > > +Contact:       "Mario LimonciellO" >                                    ^ > Looks like a typo Yep - fat fingered shift while adding t

Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-07 Thread Bernat, Yehezkel
> +Contact:       "Mario LimonciellO"                                    ^ Looks like a typo

[PATCH v2] Add driver to force WMI Thunderbolt controller power status

2017-09-07 Thread Mario Limonciello
Current implementations of Intel Thunderbolt controllers will go into a low power mode when not in use. Many machines containing these controllers also have a GPIO wired up that can force the controller awake. This is offered via a ACPI-WMI interface intended to be manipulated by a userspace util