Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-12 Thread Jiri Kosina
On Wed, 10 Dec 2014, Benjamin Tissoires wrote: > With the minors comments I expressed, this patch is: > Reviewed-by: Benjamin Tissoires Andrew, could you please resend v2 of the patch with Benjamin's comments addressed? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-12 Thread Jiri Kosina
On Wed, 10 Dec 2014, Benjamin Tissoires wrote: With the minors comments I expressed, this patch is: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Andrew, could you please resend v2 of the patch with Benjamin's comments addressed? Thanks, -- Jiri Kosina SUSE Labs -- To

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-10 Thread Benjamin Tissoires
Hi Andrew, On Mon, Dec 8, 2014 at 7:16 PM, Andrew Duggan wrote: > On 11/24/2014 03:37 PM, Andrew Duggan wrote: >> >> On composite HID devices there may be multiple HID devices on separate >> interfaces, but hid-rmi >> should only bind to the touchpad. The previous version simply checked that >>

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-10 Thread Benjamin Tissoires
Hi Andrew, On Mon, Dec 8, 2014 at 7:16 PM, Andrew Duggan adug...@synaptics.com wrote: On 11/24/2014 03:37 PM, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-08 Thread Andrew Duggan
On 11/24/2014 03:37 PM, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply checked that the interface protocol was set to mouse. Unfortuately, it is not always the

Re: [PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-12-08 Thread Andrew Duggan
On 11/24/2014 03:37 PM, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply checked that the interface protocol was set to mouse. Unfortuately, it is not always the

[PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-11-24 Thread Andrew Duggan
On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply checked that the interface protocol was set to mouse. Unfortuately, it is not always the case that the touchpad has the mouse interface

[PATCH v2] HID: rmi: Scan the report descriptor to determine if the device is suitable for the hid-rmi driver

2014-11-24 Thread Andrew Duggan
On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the touchpad. The previous version simply checked that the interface protocol was set to mouse. Unfortuately, it is not always the case that the touchpad has the mouse interface