Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-21 Thread Ahmed Abdelsalam
Hi Reji, We are going to send the patch to the mailer in the next days. As for the link local addresses, we can add a check for that and kernel returns error in case of link local and OIF not provided. We will add you and Jakub to the recipients when we send the patch. Best, Ahmed On

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Reji Thomas
Hi Ahmed, On Tue, Oct 20, 2020 at 3:04 PM Ahmed Abdelsalam wrote: > > We are submitting the patch for End.DT4. End.DX4 is already there. > > So the optional parameter and OIF applies directly to End.X/End.DX6/End.DX4. > The only catch is OIF cannot be an optional parameter for linklocal

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Reji Thomas
On Mon, Oct 19, 2020 at 9:47 PM Jakub Kicinski wrote: > > If we can save the device lookup and still be semantically correct, > that's probably better. I am afraid we need to do a device lookup if I am looking up the neighbor. neigh_lookup apis expect dev to be passed. If I go through the current

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Ahmed Abdelsalam
We are submitting the patch for End.DT4. End.DX4 is already there. So the optional parameter and OIF applies directly to End.X/End.DX6/End.DX4. On Tue, 20 Oct 2020 11:28:29 +0200 Ahmed Abdelsalam wrote: > Jakub, Reji, > > Andrea (CC'ed) and I have been working on a patch that could solve

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Ahmed Abdelsalam
Jakub, Reji, Andrea (CC'ed) and I have been working on a patch that could solve this issue. The patch allows to provide optional parameters to when SRv6 behavior. The OIF can be provided as an optional parameter when configuring SRv6 End.X, End.DX6 or End.DX4 (we are submiting in the next

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 09:25:12 +0530 Reji Thomas wrote: > > > @@ -566,7 +583,8 @@ static struct seg6_action_desc seg6_action_table[] = { > > > }, > > > { > > > .action = SEG6_LOCAL_ACTION_END_X, > > > - .attrs = (1 << SEG6_LOCAL_NH6), > > > +

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-18 Thread Reji Thomas
Hi, Please find my replies inline below. Regards Reji On Mon, Oct 19, 2020 at 4:31 AM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 13:51:19 +0530 Reji Thomas wrote: > > Currently End.X action doesn't consider the outgoing interface > > while looking up the nexthop.This breaks packet path

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-18 Thread Jakub Kicinski
On Thu, 15 Oct 2020 13:51:19 +0530 Reji Thomas wrote: > Currently End.X action doesn't consider the outgoing interface > while looking up the nexthop.This breaks packet path functionality > specifically while using link local address as the End.X nexthop. > The patch fixes this by enforcing End.X

[PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-15 Thread Reji Thomas
Currently End.X action doesn't consider the outgoing interface while looking up the nexthop.This breaks packet path functionality specifically while using link local address as the End.X nexthop. The patch fixes this by enforcing End.X action to have both nh6 and oif and using oif in lookup.It